-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubevirt: ssp: Increase timeout for tests #36544
kubevirt: ssp: Increase timeout for tests #36544
Conversation
@akrejcir: the
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/cc @ksimon1 |
/approve cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@codingben: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Would you please improve the commit message, why is this change necessary? |
Btw. I think we should rather focus on making the tests faster, because I can see in the logs, that some of the prometheus tests takes about 6 minutes per test. |
Increased timeout from the default 1 hour to 2 hours. The current tests take around 55 minutes, and if a PR adds more tests, the old timeout will not be enough.
b3cc5cf
to
a8aad77
Compare
I agree. Some of it will be solved by: https://bugzilla.redhat.com/show_bug.cgi?id=2151248 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codingben, ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse |
@akrejcir Can you please create an issue in the ssp-operator repo to track the improvement/speed up of slow tests? |
/pj-rehearse pull-ci-kubevirt-ssp-operator-master-e2e-upgrade-functests |
/pj-rehearse ack |
@akrejcir: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@akrejcir: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Increased timeout from the default 1 hour to 2 hours.