Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: ssp: Increase timeout for tests #36544

Merged

Conversation

akrejcir
Copy link
Contributor

Increased timeout from the default 1 hour to 2 hours.

@openshift-ci openshift-ci bot requested review from 0xFelix and ksimon1 February 20, 2023 09:38
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@openshift-ci-robot
Copy link
Contributor

@akrejcir: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-kubevirt-ssp-operator-master-e2e-functests kubevirt/ssp-operator presubmit Ci-operator config changed
pull-ci-kubevirt-ssp-operator-master-e2e-single-node-functests kubevirt/ssp-operator presubmit Ci-operator config changed
pull-ci-kubevirt-ssp-operator-master-e2e-upgrade-functests kubevirt/ssp-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@akrejcir
Copy link
Contributor Author

/cc @ksimon1

@akrejcir
Copy link
Contributor Author

/approve cancel
/pj-rehearse

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
Copy link

@codingben codingben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 20, 2023

@codingben: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksimon1
Copy link
Contributor

ksimon1 commented Feb 20, 2023

Would you please improve the commit message, why is this change necessary?

@ksimon1
Copy link
Contributor

ksimon1 commented Feb 20, 2023

Btw. I think we should rather focus on making the tests faster, because I can see in the logs, that some of the prometheus tests takes about 6 minutes per test.

Increased timeout from the default 1 hour to 2 hours.
The current tests take around 55 minutes, and if a PR adds
more tests, the old timeout will not be enough.
@akrejcir akrejcir force-pushed the ssp-increase-timeout branch from b3cc5cf to a8aad77 Compare February 20, 2023 12:02
@akrejcir
Copy link
Contributor Author

Btw. I think we should rather focus on making the tests faster, because I can see in the logs, that some of the prometheus tests takes about 6 minutes per test.

I agree. Some of it will be solved by: https://bugzilla.redhat.com/show_bug.cgi?id=2151248
This is mainly needed to unblock PRs.

@ksimon1
Copy link
Contributor

ksimon1 commented Feb 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codingben, ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@akrejcir
Copy link
Contributor Author

/pj-rehearse

@0xFelix
Copy link
Contributor

0xFelix commented Feb 20, 2023

@akrejcir Can you please create an issue in the ssp-operator repo to track the improvement/speed up of slow tests?

@akrejcir
Copy link
Contributor Author

Done: kubevirt/ssp-operator#500

@akrejcir
Copy link
Contributor Author

/pj-rehearse pull-ci-kubevirt-ssp-operator-master-e2e-upgrade-functests

@akrejcir
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2023

@akrejcir: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 232d237 into openshift:master Feb 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2023

@akrejcir: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key kubevirt-ssp-operator-master.yaml using file ci-operator/config/kubevirt/ssp-operator/kubevirt-ssp-operator-master.yaml

In response to this:

Increased timeout from the default 1 hour to 2 hours.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir akrejcir deleted the ssp-increase-timeout branch February 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants