-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test demonstrating zero-diff check failure #29101
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if err := runtime.DefaultUnstructuredConverter.FromUnstructured(obj.Object, castObj); err != nil { | ||
return nil, fmt.Errorf("unable to convert to OpenShiftAPIServer: %w", err) | ||
} | ||
ret, err := applyoperatorv1.ExtractOpenShiftAPIServerStatus(castObj, fieldManager) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I messed up this name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, so instead of extracting the status you were extracting the spec thus the diff!
WithMessage("Whatever")) | ||
action, err = dynamicOperatorClient.ApplyOperatorStatus(ctx, "first-condition-setter", firstConditionIdenticalToInitial) | ||
o.Expect(err).NotTo(o.HaveOccurred()) | ||
o.Expect(action).To(o.Equal("nothing to apply")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth adding one more case where we stop setting the condition and check if the first call produces a diff but the second doesn't ?
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: 3f7cf5e
|
make && ./openshift-tests run-test "[sig-apimachinery] server-side-apply zero diff detection should not update when the existing values have not changed [Suite:openshift/conformance/parallel]"
This is currently failing with