-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-39315: remove ingress operator exclusion #29093
base: master
Are you sure you want to change the base?
OCPBUGS-39315: remove ingress operator exclusion #29093
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kannon92: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@kannon92 I investigated the logs here and I don't see any issues for cluster-ingress. Do you? |
/payload 4.18 informing |
yea, i think we gotta search for a job that actually triggers this. Not sure if it is covered in the default presubmits. |
/payload 4.18 nightly informing |
@kannon92: trigger 72 job(s) of type informing for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/708127f0-7111-11ef-8a2a-3bc56ba8cbf2-0 |
/payload 4.18 nightly blocking |
@kannon92: trigger 9 job(s) of type blocking for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/538d1480-7128-11ef-8c0b-e7390bea2fd0-0 |
If we can't find any failures, I'm happy to merge this PR. And we can monitor the CI to see if this failure occurs again. |
@kannon92 let me know if there's anything else I can do. It's not clear to me how to find issues in the payload tests you ran. |
@kannon92, I don't see any restarts for cluster-ingress-operator in CI. @openshift/openshift-team-network-edge is fine with the change. Do you want to remove the "wip" from the commit message and link this to OCPBUGS-39315? |
4375a9e
to
f409bd2
Compare
@kannon92: This pull request references Jira Issue OCPBUGS-39315, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kannon92: This pull request references Jira Issue OCPBUGS-39315, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kannon92: This pull request references Jira Issue OCPBUGS-39315, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
done! |
/hold A related PR was reverted so going to hold on this one for now. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kannon92: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: f409bd2
|
Gentle nudge! @kannon92, is there any update on the related PR? Are we going to proceed with this PR? |
cc @candita