Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-39315: remove ingress operator exclusion #29093

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kannon92
Copy link
Contributor

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kannon92 kannon92 changed the title wip: remove ingress operator exclusion to help debug issue NO-JIRA: remove ingress operator exclusion to help debug issue Sep 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2024
@openshift-ci-robot
Copy link

@kannon92: This pull request explicitly references no jira issue.

In response to this:

cc @candita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
@candita
Copy link
Contributor

candita commented Sep 12, 2024

@kannon92 I investigated the logs here and I don't see any issues for cluster-ingress. Do you?

@kannon92
Copy link
Contributor Author

/payload 4.18 informing

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@kannon92: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@kannon92
Copy link
Contributor Author

@kannon92 I investigated the logs here and I don't see any issues for cluster-ingress. Do you?

@kannon92 I investigated the logs here and I don't see any issues for cluster-ingress. Do you?

yea, i think we gotta search for a job that actually triggers this. Not sure if it is covered in the default presubmits.

@kannon92
Copy link
Contributor Author

/payload 4.18 nightly informing

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@kannon92: trigger 72 job(s) of type informing for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-agent-compact-ipv4-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-agent-ha-dualstack-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-agent-single-node-ipv6
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.18-console-aws
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.18-periodics-e2e-aws
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-csi
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-cgroupsv2
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-fips
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node-csi
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node-serial
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node-techpreview
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.18-upgrade-from-stable-4.17-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-upi
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.18-periodics-e2e-azure
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-azure-csi
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-cnv-nightly-4.18-e2e-azure-deploy-cnv
  • periodic-ci-openshift-release-master-cnv-nightly-4.18-e2e-azure-upgrade-cnv
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-driver-toolkit
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.18-periodics-e2e-gcp
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-rt
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-serial-ipv4
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-serial-virtualmedia
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.18-upgrade-from-stable-4.17-e2e-metal-ipi-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-serial-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-serial-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.18-upgrade-from-stable-4.17-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ovn-assisted
  • periodic-ci-openshift-release-master-nightly-4.18-metal-ovn-single-node-recert-cluster-rename
  • periodic-ci-openshift-osde2e-main-nightly-4.18-osd-aws
  • periodic-ci-openshift-osde2e-main-nightly-4.18-conformance-osd-aws
  • periodic-ci-openshift-osde2e-main-nightly-4.18-osd-gcp
  • periodic-ci-openshift-osde2e-main-nightly-4.18-conformance-osd-gcp
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-proxy
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ovn-single-node-live-iso
  • periodic-ci-openshift-osde2e-main-nightly-4.18-rosa-classic-sts
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-telco5g
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-vsphere-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-upi
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-upi-serial
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-static-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/708127f0-7111-11ef-8a2a-3bc56ba8cbf2-0

@kannon92
Copy link
Contributor Author

/payload 4.18 nightly blocking

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@kannon92: trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/538d1480-7128-11ef-8c0b-e7390bea2fd0-0

@kannon92
Copy link
Contributor Author

If we can't find any failures, I'm happy to merge this PR. And we can monitor the CI to see if this failure occurs again.

@candita
Copy link
Contributor

candita commented Sep 13, 2024

@kannon92 let me know if there's anything else I can do. It's not clear to me how to find issues in the payload tests you ran.

@Miciah
Copy link
Contributor

Miciah commented Sep 17, 2024

@kannon92, I don't see any restarts for cluster-ingress-operator in CI. @openshift/openshift-team-network-edge is fine with the change. Do you want to remove the "wip" from the commit message and link this to OCPBUGS-39315?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@kannon92 kannon92 force-pushed the remove-ingress-operator-exception branch from 4375a9e to f409bd2 Compare September 19, 2024 13:38
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@kannon92 kannon92 changed the title NO-JIRA: remove ingress operator exclusion to help debug issue OCPBUGS-39315: remove ingress operator exclusion Sep 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 19, 2024
@openshift-ci-robot
Copy link

@kannon92: This pull request references Jira Issue OCPBUGS-39315, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

cc @candita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kannon92
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@kannon92: This pull request references Jira Issue OCPBUGS-39315, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kannon92
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 19, 2024
@openshift-ci-robot
Copy link

@kannon92: This pull request references Jira Issue OCPBUGS-39315, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 19, 2024
@kannon92
Copy link
Contributor Author

@kannon92, I don't see any restarts for cluster-ingress-operator in CI. @openshift/openshift-team-network-edge is fine with the change. Do you want to remove the "wip" from the commit message and link this to OCPBUGS-39315?

done!

@kannon92
Copy link
Contributor Author

/hold

A related PR was reverted so going to hold on this one for now.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2024
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@kannon92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade f409bd2 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-ipsec-serial f409bd2 link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-aws-ovn-single-node-upgrade f409bd2 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/unit f409bd2 link true /test unit
ci/prow/e2e-gcp-ovn-builds f409bd2 link true /test e2e-gcp-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: f409bd2

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-api-machinery] disruption/kube-api connection/reused should be available throughout the test
This test has passed 99.94% of 6408 runs on release 4.18 [Overall] in the last week.
---
[sig-api-machinery] disruption/kube-api connection/new should be available throughout the test
This test has passed 99.75% of 6408 runs on release 4.18 [Overall] in the last week.

@Miciah
Copy link
Contributor

Miciah commented Nov 19, 2024

/hold

A related PR was reverted so going to hold on this one for now.

Gentle nudge! @kannon92, is there any update on the related PR? Are we going to proceed with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants