-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Enable upstream virtualization operator E2E tests. #1556
CI: Enable upstream virtualization operator E2E tests. #1556
Conversation
Use this to tweak the subscription settings and some expected namespaces. Signed-off-by: Matthew Arnold <[email protected]>
Signed-off-by: Matthew Arnold <[email protected]>
Signed-off-by: Matthew Arnold <[email protected]>
Signed-off-by: Matthew Arnold <[email protected]>
Going to try to keep everything in openshift-virtualization-os-images namespace instead. Installing this CRD as-is fails because kubevirt-os-images does not exist yet. Signed-off-by: Matthew Arnold <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sane. Thank you!
/retest-required |
Signed-off-by: Matthew Arnold <[email protected]>
The community KubeVirt operator puts these in "kubevirt-os-images", but to keep fixed YAML templates the test needs them in "openshift-virtualization-os-images". This adds a way to copy an existing data source to a new namespace. Signed-off-by: Matthew Arnold <[email protected]>
Undo temporary change to force community operator in tests. Signed-off-by: Matthew Arnold <[email protected]>
/retest |
4.17 is failing again.. |
/test 4.17-e2e-test-kubevirt-aws |
1 similar comment
/test 4.17-e2e-test-kubevirt-aws |
/test 4.16-e2e-test-kubevirt-aws |
/test 4.17-e2e-test-kubevirt-aws |
I finally managed to catch this live, looks like a problem with cloning the VM disk.
I will check how this is supposed to work normally. |
Signed-off-by: Matthew Arnold <[email protected]>
Trying to work around image clone failure in CI. Signed-off-by: Matthew Arnold <[email protected]>
a663e29
This reverts commit a663e29. Signed-off-by: Matthew Arnold <[email protected]>
/test 4.14-e2e-test-aws |
/override 4.17-e2e-test-kubevirt-aws This is fixed upstream: kubevirt/containerized-data-importer#3434 I think it should be okay to override until the fix makes its way downstream. |
/test 4.18-dev-preview-e2e-test-aws |
@mrnold: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/4.17-e2e-test-kubevirt-aws |
@mrnold: Overrode contexts on behalf of mrnold: ci/prow/4.17-e2e-test-kubevirt-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4.18 is safe to ignore for now due to #1555 |
/override 4.18-dev-preview-e2e-test-aws |
@kaovilai: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/4.18-dev-preview-e2e-test-aws |
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.18-dev-preview-e2e-test-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mrnold: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mrnold, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
20d8c61
into
openshift:master
Why the changes were made
An early test of OpenShift 4.18 did not have the virtualization operator available in the usual place yet. This pull request enables testing with the upstream community KubeVirt operator with a new HCO_UPSTREAM test option.
How to test the changes made
make TEST_VIRT=true HCO_UPSTREAM=true test-e2e