Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable upstream virtualization operator E2E tests. #1556

Merged
merged 11 commits into from
Oct 22, 2024

Conversation

mrnold
Copy link
Contributor

@mrnold mrnold commented Oct 14, 2024

Why the changes were made

An early test of OpenShift 4.18 did not have the virtualization operator available in the usual place yet. This pull request enables testing with the upstream community KubeVirt operator with a new HCO_UPSTREAM test option.

How to test the changes made

make TEST_VIRT=true HCO_UPSTREAM=true test-e2e

Use this to tweak the subscription settings and some expected
namespaces.

Signed-off-by: Matthew Arnold <[email protected]>
@openshift-ci openshift-ci bot requested review from hhpatel14 and mpryc October 14, 2024 01:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
Going to try to keep everything in openshift-virtualization-os-images
namespace instead. Installing this CRD as-is fails because
kubevirt-os-images does not exist yet.

Signed-off-by: Matthew Arnold <[email protected]>
kaovilai
kaovilai previously approved these changes Oct 14, 2024
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sane. Thank you!

@kaovilai
Copy link
Member

/retest-required

@mrnold mrnold changed the title CI: Enable upstream virtualization operator E2E tests. (Do not merge) CI: Enable upstream virtualization operator E2E tests. Oct 15, 2024
Signed-off-by: Matthew Arnold <[email protected]>
The community KubeVirt operator puts these in "kubevirt-os-images", but
to keep fixed YAML templates the test needs them in
"openshift-virtualization-os-images". This adds a way to copy an
existing data source to a new namespace.

Signed-off-by: Matthew Arnold <[email protected]>
Undo temporary change to force community operator in tests.

Signed-off-by: Matthew Arnold <[email protected]>
@mrnold mrnold changed the title (Do not merge) CI: Enable upstream virtualization operator E2E tests. CI: Enable upstream virtualization operator E2E tests. Oct 18, 2024
kaovilai
kaovilai previously approved these changes Oct 18, 2024
@kaovilai
Copy link
Member

/retest

@kaovilai
Copy link
Member

4.17 is failing again..

@mrnold
Copy link
Contributor Author

mrnold commented Oct 18, 2024

/test 4.17-e2e-test-kubevirt-aws

1 similar comment
@mrnold
Copy link
Contributor Author

mrnold commented Oct 18, 2024

/test 4.17-e2e-test-kubevirt-aws

@mrnold
Copy link
Contributor Author

mrnold commented Oct 18, 2024

/test 4.16-e2e-test-kubevirt-aws

@mrnold
Copy link
Contributor Author

mrnold commented Oct 18, 2024

/test 4.17-e2e-test-kubevirt-aws

@mrnold
Copy link
Contributor Author

mrnold commented Oct 18, 2024

I finally managed to catch this live, looks like a problem with cloning the VM disk.

VOLUME_MODE=filesystem
MOUNT_POINT=/var/run/cdi/clone/source
/var/run/cdi/clone/source /
Not preallocating filesystem, uploading only used bytes
UPLOAD_BYTES=22298624
I1018 21:21:51.166969 10 clone-source.go:224] content-type is "filesystem-clone"
I1018 21:21:51.167039 10 clone-source.go:225] mount is "/var/run/cdi/clone/source"
I1018 21:21:51.167043 10 clone-source.go:226] upload-bytes is 22298624
I1018 21:21:51.167051 10 clone-source.go:243] Starting cloner target
I1018 21:21:51.167092 10 clone-source.go:179] Executing /usr/bin/tar [cv -S disk.img]
I1018 21:21:51.565041 10 clone-source.go:259] Set header to filesystem-clone
F1018 21:21:51.599855 10 clone-source.go:120] Error io: read/write on closed pipe piping to gzip

I1018 21:21:51.572454 1 uploadserver.go:438] Content type header is "filesystem-clone"
I1018 21:21:51.574228 1 file.go:264] copyWithSparseCheck to /dev/cdi-block-volume
E1018 21:21:51.574515 1 file.go:282] Error zeroing range in destination file: operation not supported
E1018 21:21:51.599561 1 uploadserver.go:452] Saving stream failed: operation not supported

I will check how this is supposed to work normally.

Trying to work around image clone failure in CI.

Signed-off-by: Matthew Arnold <[email protected]>
@mrnold mrnold dismissed stale reviews from shubham-pampattiwar and kaovilai via a663e29 October 21, 2024 20:49
This reverts commit a663e29.

Signed-off-by: Matthew Arnold <[email protected]>
@mrnold
Copy link
Contributor Author

mrnold commented Oct 22, 2024

/test 4.14-e2e-test-aws

@mrnold
Copy link
Contributor Author

mrnold commented Oct 22, 2024

/override 4.17-e2e-test-kubevirt-aws

This is fixed upstream: kubevirt/containerized-data-importer#3434

I think it should be okay to override until the fix makes its way downstream.

@mrnold
Copy link
Contributor Author

mrnold commented Oct 22, 2024

/test 4.18-dev-preview-e2e-test-aws

Copy link

openshift-ci bot commented Oct 22, 2024

@mrnold: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • 4.17-e2e-test-kubevirt-aws

Only the following failed contexts/checkruns were expected:

  • ci/prow/4.14-ci-index
  • ci/prow/4.14-e2e-test-aws
  • ci/prow/4.14-e2e-test-kubevirt-aws
  • ci/prow/4.14-images
  • ci/prow/4.15-ci-index
  • ci/prow/4.15-e2e-test-aws
  • ci/prow/4.15-e2e-test-kubevirt-aws
  • ci/prow/4.15-images
  • ci/prow/4.16-ci-index
  • ci/prow/4.16-e2e-test-aws
  • ci/prow/4.16-e2e-test-kubevirt-aws
  • ci/prow/4.16-images
  • ci/prow/4.17-ci-index
  • ci/prow/4.17-e2e-test-aws
  • ci/prow/4.17-e2e-test-kubevirt-aws
  • ci/prow/4.17-images
  • ci/prow/4.18-dev-preview-ci-index
  • ci/prow/4.18-dev-preview-e2e-test-aws
  • ci/prow/4.18-dev-preview-images
  • ci/prow/images
  • ci/prow/unit-test
  • pull-ci-openshift-oadp-operator-master-4.14-ci-index
  • pull-ci-openshift-oadp-operator-master-4.14-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.14-e2e-test-kubevirt-aws
  • pull-ci-openshift-oadp-operator-master-4.14-images
  • pull-ci-openshift-oadp-operator-master-4.15-ci-index
  • pull-ci-openshift-oadp-operator-master-4.15-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.15-e2e-test-kubevirt-aws
  • pull-ci-openshift-oadp-operator-master-4.15-images
  • pull-ci-openshift-oadp-operator-master-4.16-ci-index
  • pull-ci-openshift-oadp-operator-master-4.16-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.16-e2e-test-kubevirt-aws
  • pull-ci-openshift-oadp-operator-master-4.16-images
  • pull-ci-openshift-oadp-operator-master-4.17-ci-index
  • pull-ci-openshift-oadp-operator-master-4.17-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.17-e2e-test-kubevirt-aws
  • pull-ci-openshift-oadp-operator-master-4.17-images
  • pull-ci-openshift-oadp-operator-master-4.18-dev-preview-ci-index
  • pull-ci-openshift-oadp-operator-master-4.18-dev-preview-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.18-dev-preview-images
  • pull-ci-openshift-oadp-operator-master-images
  • pull-ci-openshift-oadp-operator-master-unit-test
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override 4.17-e2e-test-kubevirt-aws

This is fixed upstream: kubevirt/containerized-data-importer#3434

I think it should be okay to override until the fix makes its way downstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrnold
Copy link
Contributor Author

mrnold commented Oct 22, 2024

/override ci/prow/4.17-e2e-test-kubevirt-aws

Copy link

openshift-ci bot commented Oct 22, 2024

@mrnold: Overrode contexts on behalf of mrnold: ci/prow/4.17-e2e-test-kubevirt-aws

In response to this:

/override ci/prow/4.17-e2e-test-kubevirt-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai
Copy link
Member

4.18 is safe to ignore for now due to #1555

@kaovilai
Copy link
Member

/override 4.18-dev-preview-e2e-test-aws

Copy link

openshift-ci bot commented Oct 22, 2024

@kaovilai: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • 4.18-dev-preview-e2e-test-aws

Only the following failed contexts/checkruns were expected:

  • ci/prow/4.14-ci-index
  • ci/prow/4.14-e2e-test-aws
  • ci/prow/4.14-e2e-test-kubevirt-aws
  • ci/prow/4.14-images
  • ci/prow/4.15-ci-index
  • ci/prow/4.15-e2e-test-aws
  • ci/prow/4.15-e2e-test-kubevirt-aws
  • ci/prow/4.15-images
  • ci/prow/4.16-ci-index
  • ci/prow/4.16-e2e-test-aws
  • ci/prow/4.16-e2e-test-kubevirt-aws
  • ci/prow/4.16-images
  • ci/prow/4.17-ci-index
  • ci/prow/4.17-e2e-test-aws
  • ci/prow/4.17-e2e-test-kubevirt-aws
  • ci/prow/4.17-images
  • ci/prow/4.18-dev-preview-ci-index
  • ci/prow/4.18-dev-preview-e2e-test-aws
  • ci/prow/4.18-dev-preview-images
  • ci/prow/images
  • ci/prow/unit-test
  • pull-ci-openshift-oadp-operator-master-4.14-ci-index
  • pull-ci-openshift-oadp-operator-master-4.14-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.14-e2e-test-kubevirt-aws
  • pull-ci-openshift-oadp-operator-master-4.14-images
  • pull-ci-openshift-oadp-operator-master-4.15-ci-index
  • pull-ci-openshift-oadp-operator-master-4.15-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.15-e2e-test-kubevirt-aws
  • pull-ci-openshift-oadp-operator-master-4.15-images
  • pull-ci-openshift-oadp-operator-master-4.16-ci-index
  • pull-ci-openshift-oadp-operator-master-4.16-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.16-e2e-test-kubevirt-aws
  • pull-ci-openshift-oadp-operator-master-4.16-images
  • pull-ci-openshift-oadp-operator-master-4.17-ci-index
  • pull-ci-openshift-oadp-operator-master-4.17-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.17-e2e-test-kubevirt-aws
  • pull-ci-openshift-oadp-operator-master-4.17-images
  • pull-ci-openshift-oadp-operator-master-4.18-dev-preview-ci-index
  • pull-ci-openshift-oadp-operator-master-4.18-dev-preview-e2e-test-aws
  • pull-ci-openshift-oadp-operator-master-4.18-dev-preview-images
  • pull-ci-openshift-oadp-operator-master-images
  • pull-ci-openshift-oadp-operator-master-unit-test
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override 4.18-dev-preview-e2e-test-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai
Copy link
Member

/override ci/prow/4.18-dev-preview-e2e-test-aws

Copy link

openshift-ci bot commented Oct 22, 2024

@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.18-dev-preview-e2e-test-aws

In response to this:

/override ci/prow/4.18-dev-preview-e2e-test-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Oct 22, 2024

@mrnold: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
Copy link

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mrnold, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mrnold,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 20d8c61 into openshift:master Oct 22, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants