OCPBUGS-43925: BuildConfig form breaks on manually enter the Git URL

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-43925

Analysis / Root cause:
While getting git type value from fromik value fieldPrefix was not considered

Solution Description:
Updated GitTypeSelector component to consider fieldPrefix while fetching git type

Screen shots / Gifs for design review:

-------- BuildConfig form-----

Screen.Recording.2024-10-30.at.11.11.30.AM.mov

---

-------- Import from git form-----

Screen.Recording.2024-10-30.at.11.13.24.AM.mov

---

-------- Create serverless form-----

Screen.Recording.2024-10-30.at.11.14.27.AM.mov

Unit test coverage report:
NA

Test setup:

1. Navigate to Create BuildConfig form page
2. Select source type as Git
3. Enter the git url by typing manually do not paste or select from the suggestion

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-43925, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-43925

Analysis / Root cause:
While getting git type value from fromik value fieldPrefix was not considered

Solution Description:
Updated GitTypeSelector component to consider fieldPrefix while fetching git type

Screen shots / Gifs for design review:

-------- BuildConfig form-----

Screen.Recording.2024-10-30.at.11.11.30.AM.mov

---

-------- Import from git form-----

Screen.Recording.2024-10-30.at.11.13.24.AM.mov

---

-------- Create serverless form-----

Screen.Recording.2024-10-30.at.11.14.27.AM.mov

Unit test coverage report:
NA

Test setup:

1. Navigate to Create BuildConfig form page
2. Select source type as Git
3. Enter the git url by typing manually do not paste or select from the suggestion

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/retest

[Lucifergene]

The fix works as expected.
I've added some more edits to this file to ensure consistency. I've adjusted the formatting to match the pattern observed in the other files.

[Lucifergene]

Thanks for the revision

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [Lucifergene,lokanandaprabhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1533f64 and 2 for PR HEAD fa253e2 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2bce638 and 1 for PR HEAD fa253e2 in total

[lokanandaprabhu]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2c069cb and 2 for PR HEAD fa253e2 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 02adeca and 1 for PR HEAD fa253e2 in total

[openshift-ci]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.