Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user guide documentation to perform upgrade #299

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sudomakeinstall2
Copy link
Contributor

No description provided.

- Make sure upgrade-defaults-configmap is immutable
- Set ProvisioningState status when updating UpgradeCompleted condition

Signed-off-by: Saeid Askari <[email protected]>
For upgrade process AgentClusterInstall should be added to
ClusterInstance's suppressedManifests in order to prevent updates to it.
This commit fixes suppressedManifests getting removed on subsequent
reconciles after adding on the first reconcile.

Signed-off-by: Saeid Askari <[email protected]>
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sudomakeinstall2. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sudomakeinstall2
Copy link
Contributor Author

/hold wait for other PR's to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
Copy link

openshift-ci bot commented Nov 4, 2024

@sudomakeinstall2: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-job fbd12cc link true /test ci-job

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant