deploying services automatically #284
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @mmorency2021. Thanks for your PR. I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| ifndef ignore-not-found | ||
| ignore-not-found = false | ||
| ignore-not-found = true |
| @@ -171,8 +171,11 @@ docker-buildx: ## Build and push docker image for the manager for cross-platform | |||
|
|
|||
| ##@ Deployment | |||
|
|
|||
| CLOUD_ID := $(shell oc get clusterversion -o jsonpath='{.items[].spec.clusterID}{"\n"}') | |||
| INGRESS_HOST := o2ims.$(shell oc get ingresscontrollers.operator.openshift.io -n openshift-ingress-operator default -o jsonpath='{.status.domain}{"\n"}') | |||
There was a problem hiding this comment.
These two lines need to be removed.
| @@ -187,7 +190,12 @@ uninstall: manifests kustomize kubectl ## Uninstall CRDs from the K8s cluster sp | |||
| deploy: manifests kustomize kubectl ## Deploy controller to the K8s cluster specified in ~/.kube/config. | |||
| @$(KUBECTL) create configmap env-config --from-literal=HWMGR_PLUGIN_NAMESPACE=$(HWMGR_PLUGIN_NAMESPACE) --dry-run=client -o yaml > config/manager/env-config.yaml | |||
| cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG} | |||
| cp config/manager/inventory.yaml config/manager/inventory.back | |||
| sed -i 's/ingressHost:.*/ingressHost: $(INGRESS_HOST)/' config/manager/inventory.yaml | |||
There was a problem hiding this comment.
The ingress host handling needs to be removed. This will be handled automatically with the patch that I provided you.
| $(KUSTOMIZE) build config/$(KUSTOMIZE_OVERLAY) | $(KUBECTL) apply -f - | ||
| cp config/manager/inventory.back config/manager/inventory.yaml | ||
| rm -f config/manager/inventory.back |
There was a problem hiding this comment.
I'm not really sure I understand what is being accomplished with the copying of the inventory.yaml file. Could you explain why this is necessary.
There was a problem hiding this comment.
This file should be removed from your commit
| newName: quay.io/openshift-kni/oran-o2ims-operator | ||
| newTag: 4.16.0 | ||
| newName: quay.io/mmorency0/oran-o2ims | ||
| newTag: latest |
There was a problem hiding this comment.
This should not be included in your PR.
There was a problem hiding this comment.
This should not be included in your PR
this PR is about below changes