-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that NROP metrics are served securely #902
base: main
Are you sure you want to change the base?
Ensure that NROP metrics are served securely #902
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swatisehgal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
150810d
to
f389e86
Compare
f389e86
to
db427c5
Compare
db427c5
to
ff40ca8
Compare
ff40ca8
to
2b34208
Compare
Signed-off-by: Swati Sehgal <[email protected]>
2b34208
to
85a2139
Compare
Signed-off-by: Swati Sehgal <[email protected]>
5e21de9
to
1256518
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@swatisehgal: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add Kube-rbac-proxy side car container to NROP deployment to ensure that NROP metrics are served securely.
Reference doc: https://rhobs-handbook.netlify.app/products/openshiftmonitoring/collecting_metrics.md/