[release-4.17] MGMT-19028: IBI only apply the first resource in a file with multiple resources added as extra manifests #671
Conversation
… resources added as extra manifests The issue is fixed by getting a NewYAMLOrJSONDecoder, and decodeing each resource incrementally in a loop until the end of the file is reached. This ensures the code read the entier file in case we get multiple definitions in a single file. Note that the applyManifests (used buth by IBU and IBI) will apply the resources in the order they are listed in the file without any dependency awareness. For example, if you list a Pod before the Namespace it depends on, IBI will still apply the Pod first unless you specifically handle ordering in the manifest file. Signed-off-by: Eran Cohen <[email protected]>
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-19028 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test images |
This is an automated cherry-pick of #662
/assign tsorya