Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upversion golang to 1.22 #668

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sudomakeinstall2
Copy link
Contributor

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Signed-off-by: Saeid Askari <[email protected]>
@openshift-ci openshift-ci bot requested review from rauhersu and tsorya October 3, 2024 15:32
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eranco74 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rauhersu
Copy link

rauhersu commented Oct 3, 2024

/hold

We need to incorporate these changes in downstream first, also you might want to take a look at openshift ci (if this has not been coordinated) as quay.io builds will likely need to update the builders too.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@rauhersu
Copy link

rauhersu commented Oct 4, 2024

/unhold

All good !

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2024
@jc-rh
Copy link
Member

jc-rh commented Oct 15, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

@sudomakeinstall2: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-job a071534 link true /test ci-job
ci/prow/ibi-e2e-flow a071534 link false /test ibi-e2e-flow
ci/prow/ibu-e2e-flow a071534 link false /test ibu-e2e-flow
ci/prow/images a071534 link true /test images
ci/prow/ci-index a071534 link true /test ci-index
ci/prow/integration a071534 link true /test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants