Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build env update for linux on arm #651

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jc-rh
Copy link
Member

@jc-rh jc-rh commented Sep 6, 2024

Background / Context

Several LCA developers are on M3 Macbooks running linux VMs now. This update enables building x64 images locally with the toolchain for arm64/aarch64 linux.

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jc-rh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jc-rh
Copy link
Member Author

jc-rh commented Sep 6, 2024

/assign @pixelsoccupied

@pixelsoccupied
Copy link
Contributor

build time went down from minutes to seconds! thanks for update!!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@jc-rh
Copy link
Member Author

jc-rh commented Sep 6, 2024

/cc @rauhersu @fontivan
This is not a real dockfile change. You can decide whether to take it, unless it's possible that d/s infra may use arm machines someday

@fontivan
Copy link

fontivan commented Sep 6, 2024

/cc @rauhersu @fontivan This is not a real dockfile change. You can decide whether to take it, unless it's possible that d/s infra may use arm machines someday

I like the idea, though I think it would be even better if we could specify a target architecture with GOARCH like I had done here for NTO: openshift/cluster-node-tuning-operator#1135

@jc-rh
Copy link
Member Author

jc-rh commented Sep 6, 2024

/cc @rauhersu @fontivan This is not a real dockfile change. You can decide whether to take it, unless it's possible that d/s infra may use arm machines someday

I like the idea, though I think it would be even better if we could specify a target architecture with GOARCH like I had done here for NTO: openshift/cluster-node-tuning-operator#1135

Building arm images is beyond the scope of this PR. I am happy to make that change if I can verify the output. Does NTO get CI running on arm hardware now?

@fontivan
Copy link

fontivan commented Sep 6, 2024

/cc @rauhersu @fontivan This is not a real dockfile change. You can decide whether to take it, unless it's possible that d/s infra may use arm machines someday

I like the idea, though I think it would be even better if we could specify a target architecture with GOARCH like I had done here for NTO: openshift/cluster-node-tuning-operator#1135

Building arm images is beyond the scope of this PR. I am happy to make that change if I can verify the output. Does NTO get CI running on arm hardware now?

I'm not sure what architecture the CI runs on but the change was very useful for testing since by using GOARCH you can build any arch from any arch (within the supported golang limits)

@tsorya
Copy link
Contributor

tsorya commented Sep 18, 2024

/test integration

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants