Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ztp: Reference: make SriovNetworkNodePolicy more flexible #2030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

borball
Copy link
Contributor

@borball borball commented Sep 12, 2024

This is to fix the issue below that isRdma and priority are reported as unexpected with null value on the live cluster:

--- /tmp/MERGED-3869953538/sriovnetwork-openshift-io-v1_sriovnetworknodepolicy_openshift-sriov-network-operator_pci-sriov 2024-09-12 15:31:10.502529916 +0000
+++ /tmp/LIVE-1145655967/sriovnetwork-openshift-io-v1_sriovnetworknodepolicy_openshift-sriov-network-operator_pci-sriov 2024-09-12 15:31:10.502529916 +0000
@@ -5,12 +5,10 @@
   namespace: openshift-sriov-network-operator
 spec:
   deviceType: netdevice
-  isRdma: null
   nicSelector:
     pfNames:
     - '%!s(<nil>)#0-3'
   nodeSelector:
     node-role.kubernetes.io/master: ""
   numVfs: 8
-  priority: null
   resourceName: pci_sriov

This is to fix the issue below that isRdma and priority are reported as unexpected with null value on the live cluster:

--- /tmp/MERGED-3869953538/sriovnetwork-openshift-io-v1_sriovnetworknodepolicy_openshift-sriov-network-operator_pci-sriov  2024-09-12 15:31:10.502529916 +0000
+++ /tmp/LIVE-1145655967/sriovnetwork-openshift-io-v1_sriovnetworknodepolicy_openshift-sriov-network-operator_pci-sriov	2024-09-12 15:31:10.502529916 +0000
@@ -5,12 +5,10 @@
   namespace: openshift-sriov-network-operator
 spec:
   deviceType: netdevice
-  isRdma: null
   nicSelector:
     pfNames:
     - '%!s(<nil>)#0-3'
   nodeSelector:
     node-role.kubernetes.io/master: ""
   numVfs: 8
-  priority: null
   resourceName: pci_sriov
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: borball
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

Hi @borball. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2024
@sabbir-47
Copy link
Contributor

/assign @lack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants