Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing cancelled and resource_stats to /_reindex/{task_id}/_rethrottle. #740

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Added missing cancelled and resource_stats to /_reindex/{task_id}/_rethrottle. #740

merged 2 commits into from
Dec 17, 2024
+51 −2

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 17, 2024

Description

Added missing cancelled and resource_stats to /_reindex/{task_id}/_rethrottle.

Issues Resolved

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock force-pushed the reindex-rethrottle branch from 8b3690e to ea934d6 Compare December 17, 2024 14:44
@dblock dblock force-pushed the reindex-rethrottle branch from ea934d6 to 5122560 Compare December 17, 2024 14:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Changes Analysis

Commit SHA: fe241eb
Comparing To SHA: 4226d83

API Changes

Summary

├─┬Paths
│ └─┬/_reindex/{task_id}/_rethrottle
│   └─┬POST
│     └──[🔀] description (8014:20)
└─┬Components
  └─┬_core.reindex_rethrottle___ReindexTask
    ├──[➕] properties (44117:9)
    └──[➕] properties (44125:9)
Document Element Total Changes Breaking Changes
paths 1 0
components 2 0
  • Total Changes: 3
  • Modifications: 1
  • Additions: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12378981031/artifacts/2333588717

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Spec Test Coverage Analysis

Total Tested
536 528 (98.51 %)

@dblock
Merge branch 'main' into reindex-rethrottle
fe241eb 
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
Tokesh
Tokesh approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@Tokesh Tokesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@Tokesh Tokesh merged commit 051e042 into opensearch-project:main Dec 17, 2024
29 checks passed
@dblock dblock deleted the reindex-rethrottle branch December 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tokesh Tokesh Tokesh approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong nhtruong is a code owner

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @Tokesh