Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added specs and tests for /_plugins/_transform. #722

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 10, 2024

Description

Added/corrected responses for /_plugins/_transform.

Issues Resolved

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Changes Analysis

Commit SHA: 1bc79c2
Comparing To SHA: 4f28c29

API Changes

Summary

├─┬Paths
│ ├─┬/_plugins/_transform/{id}
│ │ ├─┬GET
│ │ │ └─┬Responses
│ │ │   └─┬200
│ │ │     └─┬application/json
│ │ │       └─┬Schema
│ │ │         └──[🔀] $ref (59376:13)❌ 
│ │ ├─┬PUT
│ │ │ ├─┬Responses
│ │ │ │ ├──[➕] codes (31933:7)
│ │ │ │ └─┬200
│ │ │ │   └─┬application/json
│ │ │ │     └─┬Schema
│ │ │ │       └──[🔀] $ref (59376:13)❌ 
│ │ │ └─┬Requestbody
│ │ │   └─┬application/json
│ │ │     └─┬Schema
│ │ │       └──[🔀] $ref (59369:13)❌ 
│ │ └─┬DELETE
│ │   └─┬Responses
│ │     └─┬200
│ │       └──[➕] content (31905:11)
│ └─┬/_plugins/_transform/_preview
│   └─┬POST
│     └─┬Requestbody
│       └──application/json
└─┬Components
  ├──[➕] responses (31933:7)
  ├──[➖] schemas (59228:7)❌ 
  ├──[➖] schemas (59217:7)❌ 
  ├──[➖] schemas (59314:7)❌ 
  ├──[➕] schemas (59180:7)
  ├──[➕] schemas (59369:7)
  ├──[➕] schemas (59219:7)
  ├──[➕] schemas (59376:7)
  ├──[➕] schemas (59214:7)
  ├─┬transforms._common___TransformsResponse
  │ └─┬transforms
  │   └─┬Schema
  │     └──[🔀] $ref (59376:13)❌ 
  ├─┬transforms._common___Explain
  │ ├─┬metadata_id
  │ │ └──[🔀] type (59235:13)❌ 
  │ └─┬transform_metadata
  │   └──[🔀] $ref (59238:11)❌ 
  └─┬transforms._common___Transform
    ├─┬aggregations
    │ ├──[➕] additionalProperties (59352:13)❌ 
    │ ├──[➖] items (59312:13)❌ 
    │ └──[🔀] type (59350:17)❌ 
    ├─┬enabled_at
    │ └──[🔀] type (59329:13)❌ 
    ├─┬metadata_id
    │ └──[🔀] type (59321:13)❌ 
    └─┬updated_at
      └──[🔀] type (59324:17)❌ 

Document Element Total Changes Breaking Changes
paths 5 3
components 18 12
  • BREAKING Changes: 15 out of 23
  • Modifications: 10
  • Removals: 4
  • Additions: 9
  • Breaking Removals: 4
  • Breaking Modifications: 10
  • Breaking Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12263435686/artifacts/2301936562

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

@dblock dblock force-pushed the transforms branch 2 times, most recently from 7e43836 to 6e1631a Compare December 10, 2024 13:51
@dblock dblock changed the title Added specs and test for /_plugins/_transform. Added specs and tests for /_plugins/_transform. Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Spec Test Coverage Analysis

Total Tested
536 467 (87.13 %)

nhtruong
nhtruong previously approved these changes Dec 10, 2024
@nhtruong nhtruong merged commit 6341e87 into opensearch-project:main Dec 10, 2024
28 checks passed
@dblock dblock deleted the transforms branch December 10, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants