Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search shards API tests #709

Merged
merged 13 commits into from
Dec 9, 2024
Merged

Conversation

Tokesh
Copy link
Collaborator

@Tokesh Tokesh commented Dec 7, 2024

Description

GET /{index}/_search_shards
POST /{index}/_search_shards
GET /_search_shards
POST /_search_shards

Issues Resolved

#663

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 7, 2024

Changes Analysis

Commit SHA: 05e30ec
Comparing To SHA: bbc0d9a

API Changes

Summary

├─┬Paths
│ ├─┬/{index}/_search_shards
│ │ ├─┬GET
│ │ │ └──[➕] requestBody (27335:7)❌ 
│ │ └─┬POST
│ │   └──[➕] requestBody (27335:7)❌ 
│ └─┬/_search_shards
│   ├─┬GET
│   │ └──[➕] requestBody (27335:7)❌ 
│   └─┬POST
│     └──[➕] requestBody (27335:7)❌ 
└─┬Components
  └──[➕] requestBodies (27335:7)

Document Element Total Changes Breaking Changes
paths 4 4
components 1 0
  • BREAKING Changes: 4 out of 5
  • Additions: 5
  • Breaking Additions: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12211770046/artifacts/2288394768

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

Copy link
Contributor

github-actions bot commented Dec 7, 2024

Spec Test Coverage Analysis

Total Tested
528 427 (80.87 %)

@Tokesh Tokesh marked this pull request as ready for review December 9, 2024 08:27
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next time, "indexes" is what the documentation uses for indices, opensearch-project/documentation-website#8696

additionalProperties:
type: object
indices_boost:
description: Allows increasing the relevance of specific indices in the search.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Allows increasing the relevance of specific indices in the search.
description: Allows increasing the relevance of specific indexes in the search.

@dblock dblock merged commit 8146594 into opensearch-project:main Dec 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants