-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding rank_eval indices
API tests
#704
Conversation
Signed-off-by: Tokesh <[email protected]>
Changes AnalysisCommit SHA: 866897a API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12146406371/artifacts/2269346061 API Coverage
|
Signed-off-by: Tokesh <[email protected]>
1.3.x returns |
Signed-off-by: Tokesh <[email protected]>
Spec Test Coverage Analysis
|
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Niyazbek Torekeldi <[email protected]>
Signed-off-by: Tokesh <[email protected]>
…to rank-eval-tests
Signed-off-by: Tokesh <[email protected]>
I think its ready for review, open to any suggestions :) |
@@ -134,7 +134,7 @@ components: | |||
additionalProperties: | |||
type: object | |||
additionalProperties: | |||
type: object | |||
type: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these are always numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to read it in the future, most likely yes.
If I notice it's not, I'll open a new pull request.
Description
test for:
GET /_rank_eval
POST /_rank_eval
GET /{index}/_rank_eval
POST /{index}/_rank_eval
Issues Resolved
[#663 ]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.