-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index Upgrade
API specs and tests for them
#690
Conversation
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Niyazbek Torekeldi <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Niyazbek Torekeldi <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Spec Test Coverage Analysis
|
Upgrade
API specs and tests for them
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Changes AnalysisCommit SHA: 481692a API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12104083308/artifacts/2257912337 API Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's find out when this was deprecated and why and put a real version number here. What message do you get (aka how do you know it's deprecated)? Look for it in https://github.com/opensearch-project/opensearch and narrow down the commit / PR that did it.
tests/default/indices/upgrade.yaml
Outdated
- {create: {_index: movies, _id: movie2}} | ||
- {director: Nicolas Winding Refn, title: Drive, year: 1960} | ||
chapters: | ||
- synopsis: Check index upgrade status (GET). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good to flip this one with the triggering of an upgrade so we can get actual results and check schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood you correctly, then I have corrected
Hello! I found that, the _upgrade API was deprecated in Elasticsearch 7.10, which is precisely the version OpenSearch was forked from. And I've also added tests for: |
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
response: | ||
status: 200 | ||
|
||
- synopsis: Trigger upgrade (POST). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not an /{index}
API and should go in its own tests/default/_core/upgrade.yaml
. I'll merge now, but appreciate it being split in a future PR.
Description
API specs and tests for upgrade api
And marking them deprecated
GET /_upgrade
POST /_upgrade
GET /{index}/_upgrade
POST /{index}/_upgrade
Issues Resolved
[#663]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.