Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Index API Spec Tests, Part 1 #678

Merged
merged 23 commits into from
Nov 24, 2024
Merged

Add missing Index API Spec Tests, Part 1 #678

merged 23 commits into from
Nov 24, 2024

Conversation

Tokesh
Copy link
Collaborator

@Tokesh Tokesh commented Nov 17, 2024 •
edited
Loading

Description

Adding tests for this API list:
POST /{index}/_mapping
GET /{index}/_mapping/field/{fields}
POST /{index}/_mget
GET /{index}/_msearch
POST /{index}/_msearch
GET /{index}/_validate/query
POST /{index}/_validate/query

Issues Resolved

[#663 ]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tokesh and others added 15 commits August 3, 2024 22:24
@Tokesh
replication added
106fd00 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
fixing lint and trying test verbose
e912e13 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
changing docker compose
bd877a8 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
Merge branch 'main' into replication-namespace
6fd6292 
Signed-off-by: Niyazbek Torekeldi <[email protected]>
@Tokesh
adding tests for replication namespace
addcd76 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
fixing lint, validate specs ci
638d60e 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
fixing docker-compose and validate specs ci
a6e0a87 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
fixing validate specs ci
b012e7b 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
trying to fix validate specs
236fea7 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
trying to fix validate specs v2
864ee68 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
Merge branch 'replication-namespace'
30fca51
@Tokesh
Merge branch 'main' of https://github.com/Tokesh/opensearch-api-speci…
1d051cd 
…fication
@Tokesh
Merge branch 'opensearch-project:main' into main
9620b94
@Tokesh
Merge remote-tracking branch 'refs/remotes/origin/main'
f847731
@Tokesh
adding not covered index api tests
42056a6 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
Copy link
Collaborator Author

Tokesh commented Nov 17, 2024

As soon as my PR with replication is merged, I will rebase it so that it doesn't interfere with checking
In the meantime, I made it a draft because I am still in the process of adding tests. I will try to do them as quickly as possible)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024 •
edited
Loading

Changes Analysis

Commit SHA: d925d04
Comparing To SHA: 8cb29a4

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11995439358/artifacts/2229473077

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

Tokesh and others added 3 commits November 23, 2024 13:30
@Tokesh
Merge branch 'main' into index-tests
7c7328c 
Signed-off-by: Niyazbek Torekeldi <[email protected]>
@Tokesh
deleting not necessary files
94915e9 
Signed-off-by: Tokesh <[email protected]>
@Tokesh
fixing lint
cf167fd 
Signed-off-by: Tokesh <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2024 •
edited
Loading

Spec Test Coverage Analysis

Total Tested
528 377 (71.4 %)

dblock
dblock requested changes Nov 23, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some asks below.

tests/default/indices/mapping.yaml Outdated Show resolved Hide resolved
tests/default/indices/msearch.yaml Outdated Show resolved Hide resolved
tests/default/indices/msearch.yaml Outdated Show resolved Hide resolved
tests/default/indices/msearch.yaml Outdated Show resolved Hide resolved
tests/default/indices/msearch.yaml Outdated Show resolved Hide resolved
tests/default/indices/refresh.yaml Outdated Show resolved Hide resolved
@dblock dblock added the skip-changelog No need to update CHANGELOG. label Nov 23, 2024
@Tokesh Tokesh marked this pull request as ready for review November 23, 2024 23:55
@Tokesh Tokesh requested a review from dblock November 23, 2024 23:55
@Tokesh Tokesh changed the title Add missing Index API Spec Tests Add missing Index API Spec Tests Part 1 Nov 23, 2024
@Tokesh Tokesh changed the title Add missing Index API Spec Tests Part 1 Add missing Index API Spec Tests, Part 1 Nov 23, 2024
@Tokesh
Copy link
Collaborator Author

Tokesh commented Nov 23, 2024

Thanks, some asks below.

Thank you for review, I have resolved the conversations and added /{index}/_validate/query API specs

dblock
dblock requested changes Nov 24, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One file name change, sorry to be annoying.

tests/default/indices/validate_query.yaml Outdated
@@ -0,0 +1,49 @@
$schema: ../../../json_schemas/test_story.schema.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be validate/query.yaml.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries! i'm really interested in working with OpenSearch in the form of tests or writing specs to understand it more deeply.

@Tokesh Tokesh requested a review from dblock November 24, 2024 10:47
@dblock dblock merged commit 962452c into opensearch-project:main Nov 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong nhtruong is a code owner

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

Assignees
No one assigned
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tokesh @dblock