Address multi-threading issues with AWS Lambda Plugin #5194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srikanth Govindarajan <[email protected]>
Signed-off-by: Srikanth Govindarajan <[email protected]>
Signed-off-by: Srikanth Govindarajan <[email protected]>
…mbda sink Signed-off-by: Srikanth Govindarajan <[email protected]>
srikanthjg
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
kkondaka
reviewed
Nov 15, 2024
| @@ -17,6 +17,6 @@ | |||
|
|
|||
| @Documented | |||
| @Retention(RetentionPolicy.RUNTIME) | |||
| @Target({ElementType.TYPE}) | |||
| @Target({ElementType.CONSTRUCTOR, ElementType.TYPE}) | |||
kkondaka
reviewed
Nov 15, 2024
| @@ -26,5 +31,6 @@ public void handleEvents(List<Event> parsedEvents, List<Record<Event>> originalR | |||
| originalAcknowledgementSet.add(responseEvent); | |||
| } | |||
| } | |||
| LOG.info("Successfully handled {} events in Aggregate response strategy", parsedEvents.size()); | |||
There was a problem hiding this comment.
This may be too many log statements
kkondaka
reviewed
Nov 15, 2024
| @@ -149,93 +155,136 @@ public Collection<Record<Event>> doExecute(Collection<Record<Event>> records) { | |||
| return records; | |||
| } | |||
|
|
|||
| //lambda mutates event | |||
| List<Record<Event>> resultRecords = new ArrayList<>(); | |||
| reentrantLock.lock(); | |||
There was a problem hiding this comment.
You shouldn't need this. This means multiple threads become serialized.
kkondaka
reviewed
Nov 15, 2024
| List<Event> parsedEvents = new ArrayList<>(); | ||
| InputStream inputStream = PayloadValidator.validateAndGetInputStream(payload); | ||
| responseCodec.parse(inputStream, record -> parsedEvents.add(record.getData())); | ||
| LOG.info("Parsed successfully"); |
There was a problem hiding this comment.
make debug/trace. This would result in too much logging. The metrics should indicate this.
kkondaka
reviewed
Nov 15, 2024
| resultRecords.add(originalRecords.get(i)); | ||
| } | ||
| }catch (Exception e){ | ||
| LOG.info("SRI ERRRRRRRRRROR",e); |
There was a problem hiding this comment.
Remove try catch here. If it fails, we need to know. Catching is not correct.
kkondaka
reviewed
Nov 15, 2024
| if (whenCondition != null && !expressionEvaluator.evaluateConditional(whenCondition, event)) { | ||
| resultRecords.add(record); | ||
| continue; | ||
| } | ||
| try { | ||
| if (currentBufferPerBatch.getEventCount() == 0) { |
There was a problem hiding this comment.
This line and next few lines look same as processor code
|
Please rebase this PR and force push so that it doesn't have any conflicts. This will help make it clearer what we are reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address multi-threading issues with AWS Lambda Plugin
Issues Resolved
Resolves #4700
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.