add file for primary fields generation in processor schema #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katherine Shen <[email protected]>
shenkw1
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Nov 12, 2024
| @@ -0,0 +1,35 @@ | |||
| { | |||
There was a problem hiding this comment.
Let's put this in the data-prepper-plugin-schema-cli project.
dlvenable
requested changes
Nov 12, 2024
| "source", "handle_failed_events" | ||
| ], | ||
| "service_map": [ | ||
| "db_path" |
There was a problem hiding this comment.
I don't think we need this one.
| "source", "default_values", "include_keys", "exclude_keys", "whitespace", "skip_duplicate_values" | ||
| ], | ||
| "parse_ion": [ | ||
| "source", "handle_failed_events" |
There was a problem hiding this comment.
I'm not sure if handle_failed_events is really a key field for these.
| "match" | ||
| ], | ||
| "key_value": [ | ||
| "source", "default_values", "include_keys", "exclude_keys", "whitespace", "skip_duplicate_values" |
There was a problem hiding this comment.
Why include skip_duplicate_values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding file for generating primary fields in processor schemas.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.