Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service. #7093

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jun 24, 2024

Description

This PR introduce the capability to display grouped navigation.

Issues Resolved

closes #7094

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

SuZhou-Joe added a commit that referenced this pull request Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 4.25532% with 90 lines in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (0215e32) to head (d37b8d4).

Files Patch % Lines
...chrome/ui/header/collapsible_nav_group_enabled.tsx 1.42% 69 Missing ⚠️
...me/ui/header/collapsible_nav_group_enabled_top.tsx 6.66% 14 Missing ⚠️
src/core/public/chrome/ui/header/header.tsx 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7093      +/-   ##
==========================================
- Coverage   67.62%   67.53%   -0.09%     
==========================================
  Files        3471     3473       +2     
  Lines       68612    68702      +90     
  Branches    11165    11190      +25     
==========================================
+ Hits        46396    46399       +3     
- Misses      19511    19597      +86     
- Partials     2705     2706       +1     
Flag Coverage Δ
Linux_1 33.20% <3.19%> (-0.06%) ⬇️
Linux_2 55.11% <4.25%> (-0.19%) ⬇️
Linux_3 45.16% <3.19%> (-0.10%) ⬇️
Linux_4 34.61% <3.19%> (-0.08%) ⬇️
Windows_1 33.22% <3.19%> (-0.06%) ⬇️
Windows_2 55.06% <4.25%> (-0.19%) ⬇️
Windows_3 45.17% <3.19%> (-0.11%) ⬇️
Windows_4 34.61% <3.19%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SuZhou-Joe added a commit that referenced this pull request Jun 24, 2024
SuZhou-Joe added a commit that referenced this pull request Jun 25, 2024
SuZhou-Joe added a commit that referenced this pull request Jun 25, 2024
@SuZhou-Joe SuZhou-Joe force-pushed the feature/left-navigation-change branch from 7b81559 to 4d724b0 Compare June 25, 2024 08:59
SuZhou-Joe added a commit that referenced this pull request Jun 25, 2024
@SuZhou-Joe SuZhou-Joe force-pushed the feature/left-navigation-change branch from 8355ea2 to 742a645 Compare June 25, 2024 09:55
SuZhou-Joe added a commit that referenced this pull request Jun 25, 2024
SuZhou-Joe added a commit that referenced this pull request Jun 26, 2024
@SuZhou-Joe SuZhou-Joe force-pushed the feature/left-navigation-change branch from 193c5ef to a3daa9f Compare June 28, 2024 03:52
SuZhou-Joe added a commit that referenced this pull request Jun 28, 2024
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 1, 2024
@SuZhou-Joe SuZhou-Joe force-pushed the feature/left-navigation-change branch from 77e8ce3 to ac790af Compare July 1, 2024 07:58
SuZhou-Joe added a commit that referenced this pull request Jul 1, 2024
SuZhou-Joe added a commit that referenced this pull request Jul 2, 2024
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 3, 2024
@SuZhou-Joe SuZhou-Joe force-pushed the feature/left-navigation-change branch from 0b12a02 to 4089a63 Compare July 3, 2024 09:04
SuZhou-Joe added a commit that referenced this pull request Jul 9, 2024
@SuZhou-Joe SuZhou-Joe force-pushed the feature/left-navigation-change branch from 899240b to d37b8d4 Compare July 12, 2024 04:51
SuZhou-Joe added a commit that referenced this pull request Jul 13, 2024
SuZhou-Joe added a commit that referenced this pull request Jul 17, 2024
SuZhou-Joe added a commit that referenced this pull request Jul 17, 2024
@SuZhou-Joe SuZhou-Joe closed this Jul 17, 2024
SuZhou-Joe added a commit that referenced this pull request Jul 18, 2024
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093)

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: enable parent nav link id

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: modify left navigation

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: modify style

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: enable left bottom

Signed-off-by: SuZhou-Joe <[email protected]>

* temp: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: save

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* temp change

Signed-off-by: SuZhou-Joe <[email protected]>

* temp change

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: overview page can not be load

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless change

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: new application

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update category based on latest design

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: do not emphasize see all link

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7230 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 18, 2024
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(opensearch-project#7093)

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: enable parent nav link id

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: modify left navigation

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: modify style

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: enable left bottom

Signed-off-by: SuZhou-Joe <[email protected]>

* temp: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: save

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* temp change

Signed-off-by: SuZhou-Joe <[email protected]>

* temp change

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: overview page can not be load

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless change

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: new application

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update category based on latest design

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: do not emphasize see all link

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR opensearch-project#7230 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe added a commit that referenced this pull request Jul 18, 2024
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093)



* feat: enable parent nav link id



* feat: modify left navigation



* feat: modify style



* feat: enable left bottom



* temp: merge



* feat: save



* feat: merge



* temp change



* temp change



* fix: overview page can not be load



* feat: remove useless change



* feat: add unit test



* feat: update snapshot



* fix: unit test error



* fix: new application



* feat: add unit test



* feat: update category based on latest design



* feat: update



* feat: update snapshot



* feat: do not emphasize see all link



* Changeset file for PR #7230 created/updated

* feat: update



* feat: update



---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 18, 2024
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093)

* feat: enable parent nav link id

* feat: modify left navigation

* feat: modify style

* feat: enable left bottom

* temp: merge

* feat: save

* feat: merge

* temp change

* temp change

* fix: overview page can not be load

* feat: remove useless change

* feat: add unit test

* feat: update snapshot

* fix: unit test error

* fix: new application

* feat: add unit test

* feat: update category based on latest design

* feat: update

* feat: update snapshot

* feat: do not emphasize see all link

* Changeset file for PR #7230 created/updated

* feat: update

* feat: update

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b28aa98)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 18, 2024
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093)

* feat: enable parent nav link id

* feat: modify left navigation

* feat: modify style

* feat: enable left bottom

* temp: merge

* feat: save

* feat: merge

* temp change

* temp change

* fix: overview page can not be load

* feat: remove useless change

* feat: add unit test

* feat: update snapshot

* fix: unit test error

* fix: new application

* feat: add unit test

* feat: update category based on latest design

* feat: update

* feat: update snapshot

* feat: do not emphasize see all link

* Changeset file for PR #7230 created/updated

* feat: update

* feat: update

---------



(cherry picked from commit b28aa98)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation-next] Add a new component to display group enabled navigation.
1 participant