Extracts configurable networking layer.

[ecgreb]

• Extracts HttpEngine interface.
• Uses LwHttp as default networking client.
• Implements alternate networking client using OkHttp.
• Tests OkHttp integration using MockWebServer.

http://square.github.io/okhttp/

[hjanetzek]

OkHttp looks very nice. I'm considering to switch over using it as default.

I've added a factory to create an engine for each loader thread. Not quite sure how to fix the tests though

[ecgreb]

@hjanetzek OkHttp is great. I've found it to be much more reliable and provide better error messaging than HttpURLConnection.

If you push your changes to a branch I can work on getting the tests passing again.

[ecgreb]

@hjanetzek oh I see the branch now... I'll take a look at this today.

[ecgreb]

$ ../gradlew clean test
Configuration on demand is an incubating feature.
:vtm-tests:clean
:vtm:compileJava UP-TO-DATE
:vtm:processResources UP-TO-DATE
:vtm:classes UP-TO-DATE
:vtm:jar UP-TO-DATE
:vtm-tests:compileJava UP-TO-DATE
:vtm-tests:processResources UP-TO-DATE
:vtm-tests:classes UP-TO-DATE
:vtm-tests:compileTestJava
:vtm-tests:processTestResources UP-TO-DATE
:vtm-tests:testClasses
:vtm-tests:test

BUILD SUCCESSFUL

Total time: 2.109 secs

[hjanetzek]

I've updated my branch. Are you ok with the api?

[ecgreb]

Looks good to me. I especially like passing a UrlTileSource into the constructor for LwHttp and OkHttpEngine. This is better than passing it on each request. Also it seems good to let the tile source handle formatting the URLs.

We may want to consider transitioning HttpEngine from an interface to an abstract class in the future so the constructor param can be enforced and common functionality can be abstracted.

[ecgreb]

@hjanetzek I pulled your latest changes and rebased onto master. Also fixed a compile error coming from a change in the jeo API.

[hjanetzek]

@ecgreb thanks, maybe I should host the latest working jeo and gdx snapshots..

I was already testing the merge in my repository, now pushed to opensciencemap/master. It's no problem to change HttpEngine to be abstract when needed.

[ecgreb]

Great thanks! We are now using the latest version of vtm with okhttp in our app.

mapzen/open#121

[hjanetzek]

@ecgreb would you mind updating okhttp to 2.0?

[ecgreb]

@hjanetzek this is definitely on our road map. Hopefully I'll have some time to work on it soon.