chore: fix husky, lint and format code #1286
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes husky using https://github.com/typicode/husky-4-to-8 and makes all necessary changes to make the linter happy. Finally, we can have linted and formatted code again!
conforms all code to our prettier specification using npm run format
|
Converted this to draft until #1285 is merged, since this sits on top of that. |
Thanks for considering this issue! I'm not sure I understand quite what you mean. Does your commit actually fix the Your commit looks to me like it just includes a different eslint and prettier configuration, without actually fixing husky. If I'm not mistaken about that, be advised that this project already has a linter and formatter configuration, which follows the |
|
This PR has a lot of conflicts but I'd like to keep it around because we can cherry-pick the configs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the husky installation to run pre-commit and commit-msg hooks again. This has not been working for a long time. Committing this also required fixing all linter errors, such that our code now actually lints again, and allowed me to finally run the formatter for the first time in ages, meaning we have linted and nicely formatted code again! 🎉