-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for changing IV and reading key / IV from nginx variables. #24
base: master
Are you sure you want to change the base?
Conversation
ade3dc5
to
5150790
Compare
653f911
to
8953ff7
Compare
cd1c747
to
c118d54
Compare
We now have the ability to decide if the IV is communicated to the client in a non forgeable manner or we only keep it on the server side. Closes openresty#2
d6f289f
to
dd9077e
Compare
Hello! Could you please also add configurable with var encrypted_session_expires? |
@artembokhan Of course. I will do this in the next two days and I'll push another commit. |
dd9077e
to
dd7470a
Compare
@artembokhan Sorry for this delay. I've just managed to commit the fix for making session_expires configurable using nginx variables. Can you please review the latest change? |
Great thank. It seems to be working for me. Unfortunately I'm just a project user so can't help with the PR review :( |
@artembokhan thank you. I'm glad it works for you. I am also using the codebase in some other projects and it works without memory leaks or segfaults :). |
Any hope to get this merged soon? |
@kim0 Not sure honestly. It has been lingering here for over 2 years now so I lost any hope. |
This PR is in conflicted state. |
There are more serious problem exist in the PR.
|
This PR closes two outstanding issues:
#2, #22 and #25 .
With these two issues resolved it is trivial to implement rotating IVs if necessary.