-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display the colormaps in docs #33
display the colormaps in docs #33
Conversation
@chrishavlin Thanks for the PR! I could see it being fine in reference! My one question would be in the doc build i'm seeing the colormaps shrink as they go down the docs, was wondering if it is a possible bug?: |
oh wow, no idea how your eyes caught that... but it does seem like some of them are a few pixels shorter. I had to pull open some screenshots in photoshop to convince myself it wasn't a weird optical illusion :) I'll try wrapping them all in extra div tags with scaling to normalize them (but may not get to it till tomorrow or Monday). Also will fix the style failures (didn't bother setting up pre-commit locally...). |
@chrishavlin So weirdly enough on mac it was doing it for me. But on my windows machine i checked, it looks fine to me haha! I have no idea what happened so could have been so weird rendering in the browser on mac for some reason. Those markers that say "under bad over" or those automatically being generated? And no worries as well! |
Ya,the under/bad/over are automatic. It's pulling the |
quick followup -- i just checked it out on my mac and in firefox it looks correct but in safari I'm seeing what you described (and it makes much more sense than the small pixel-scale differences I was looking at yesterday haha). in any case, i think i can fix it by modifying some div tags, will give it a go! |
@chrishavlin Ah makes sense, thanks for confirming! Yeah that sounds good to me! Thanks again! |
Sorry for the delay -- about to push up a change that fixes the safari display issue for me locally and removes the over/under/bad labels. To do this I added a new function (and a new test) to |
@chrishavlin No worries and thanks for the update! This looks good to me! @mgrover1 If you have time for a final review, if you could review as well. |
Great work here @chrishavlin - merging away! |
Hi there!
I spent a few mins just now plotting up all the colormaps just to check out what they're like, and then saw you're using myst-markdown for you docs, so figured it'd be easy enough to send along a PR to display all the colormaps in your docs.
One question: I added the display to the existing
# Reference
section ofapi.md
. It makes the page rather long and I could instead add agallery.md
page with just the visuals. Or I could modify the docstrings for thecm
andcm_colorblind
to remove the lists so the info isn't repeated. Or keep it as is in this PR. Any preference? I'm inclined to add agallery.md
page, but thought I'd ask first :)