add bgyp colormap #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mgrover1
approved these changes
Apr 29, 2024
|
@wx4stg I think even if this isn't the best colormap for highlighting etc, but if its still CVD friendly and a user can find use in it, I'm for adding it in. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is designed to be a correlation coefficient colormap that is more accessible than plasmidis (#24) as it does not contain a lightness reversal and therefore is easier to differentiate high correlation from low correlation areas. It also works better for black and white printing for this reason.
However, it compromises on familiarity (both NWS and plasmidis have a lightness reversal at 0.9 to 0.95 ish). This might be too much of a problem to make it 'not worth it'. I do not have any sort of color vision deficiency, but personally think that bgyp is subjectively ugly (and would vote against it's inclusion if there's a better option, which might already exist in the form of NWS_CC or plasmidis).
So this PR is a bit of grudgingly opened suggestion. Colormaps aren't supposed to be an art competition, and if it helps those with CVD, then it should definitely be included, but I'm marking this as a draft because I want to know that before 'officially' suggesting that this be included.