change-legend-entries-retrieval

[michmuel]

No description provided.

[svamaa]

Thank you @michmuel for this PR!
I prefer this solution to the other PR.
However, I could neither measure any performance win within the standart pyramid_oereb example nor within our environment in BS. Did your extracts improve in BL?

[michmuel]

@svamaa The request for the xml-extract for egrid CH958382784904 (large real estate) seems to be faster by about 1s (10s to 9s in total).

[svamaa]

Good to hear, could we get any more tests from @voisardf @peterschaer @lopo977 ?

[lopo977]

Good to hear, could we get any more tests from @voisardf @peterschaer @lopo977 ?

I just tried this branch with a 32-page extract, and here in Tessin, we see less than a 5% difference. However this branch seems also little faster.

[peterschaer]

I made a few measurements with complex extracts (large parcel, many legend items). Unfortunately, I could not observe any improvement in performance.

[michmuel]

The case where performance could be improved is limited to real estates that are covered by public law restrictions with law status "inKraft" AND "laufende Aenderungen". However, extracts for real estates only covered by plrs of law status "inKraft" should not get slower.

[svamaa]

To conclude on the recent testing:

• in 2 cases (BE & BS) it did not make any difference (I tested with parcels that do have both law status).
• in 2 cases it slightly does (TI & BL).
• There are no errors found so far.
  How shall we proceed with this PR? We could merge it if it does not harm anyone but reduces the time slightly. I'd be fine with that.

[lopo977]

If it doesn't complicate code maintenance and BL agrees, it can be merged for us (TI).

[peterschaer]

It's ok for me to merge.

[voisardf]

Same here. In favour for merging - even if the performance does not improve much. 👍

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.74%. Comparing base (86fe195) to head (ef97229).
Report is 24 commits behind head on master.

Files with missing lines	Patch %	Lines
...oereb/contrib/data_sources/standard/sources/plr.py	83.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
+ Coverage   85.51%   85.74%   +0.22%     
==========================================
  Files         120      120              
  Lines        5276     5274       -2     
==========================================
+ Hits         4512     4522      +10     
+ Misses        764      752      -12     

Flag	Coverage Δ
unittests	85.74% <91.66%> (+0.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.