Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main script config fixes #989

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Main script config fixes #989

merged 1 commit into from
Sep 25, 2024

Conversation

Hual
Copy link
Collaborator

@Hual Hual commented Sep 24, 2024

  • Fix general issue where setStrings could overwrite getStrings data before copying it, resulting in corruption; noticed when loading main scripts from file while having --script argument
  • Properly trim main scripts with repeat count

Fixes #938

@Hual
Main script config fixes
dc6ec26 
* Fix general issue where setStrings could overwrite getStrings data
  before copying it, resulting in corruption; noticed when loading main
  scripts from file while having --script argument
* Properly trim main scripts with repeat count
@Hual Hual requested a review from AmyrAhmady September 24, 2024 19:44
@AmyrAhmady AmyrAhmady merged commit cf339e4 into master Sep 25, 2024
14 checks passed
@AmyrAhmady AmyrAhmady deleted the hual/main_script_config_fixes branch September 25, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmyrAhmady AmyrAhmady AmyrAhmady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux server hangs reading legacy config (server.cfg)
2 participants
@Hual @AmyrAhmady