Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vehicle teleport bug and revert issue 735 #893

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dimmyi
Copy link
Contributor

@dimmyi dimmyi commented Mar 12, 2024

1. Forcing someone to exit spectator mode when destroying a vehicle breaks many systems.

Most admin spectator systems when a player enters a vehicle, the admin starts spectating the player's vehicle, and if some other system, for example storing the vehicle in the garage using DestroyVehicle, would force the admin to stop the mode spectator before even knowing that the player left the vehicle.

2. Stream the vehicle driver immediately to avoid the vehicle teleport bug after spectating a vehicle and have a driver. This causes the vehicle to stay in position for a moment and when the driver is StreamIn the vehicle teleports to its position.

dimmyi added 2 commits March 9, 2024 00:25
Stream the vehicle driver immediately to avoid the vehicle teleport bug after spectating a vehicle and a player is driving the vehicle.
Forcing someone to exit spectator mode when destroying a vehicle breaks many systems.

Most admin spectator systems when a player enters a vehicle, the admin starts spectating the player's vehicle, and if some other system, for example storing the vehicle in the garage using DestroyVehicle, would force the admin to stop the mode spectator before even knowing that the player left the vehicle.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NexiusTailer
Copy link
Contributor

Does the first change now make the behaviour like in samp server?

@ksenonadv
Copy link
Member

Attempting to stream the vehicle right away is indeed the right thing to do.
I'm not sure about 2nd commit, we should keep player in spectating state (client will spectate nothing basically so camera will be around 0 0 0), and reset server side spectating vehicle data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants