Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix move object rotation when optional args are not set #753

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix move object rotation when optional args are not set #753

merged 2 commits into from
Oct 26, 2023

Conversation

ksenonadv
Copy link
Member

Fixes #749

@ksenonadv ksenonadv requested a review from AmyrAhmady October 22, 2023 08:59
@xunder-matth
Copy link
Contributor

There will be cases where you want to keep only 1 or 2 axes the same, so you will pass _ (or -1000.0). However, your pull request only accounts for keeping all three parameters as default.

@AmyrAhmady AmyrAhmady merged commit 2037a95 into master Oct 26, 2023
13 checks passed
@AmyrAhmady AmyrAhmady deleted the kseny/fix_rot branch October 26, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmyrAhmady AmyrAhmady AmyrAhmady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Behavioural difference] Move(Player)Object rotation
3 participants
@ksenonadv @xunder-matth @AmyrAhmady