Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SidecarSet support in-place initContainer when k8s greater than 1.28 #1698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chengjoey
Copy link
Contributor

Ⅰ. Describe what this PR does

#1671

SidecarSet support in-place initContainer when k8s greater than 1.28

automatically determines whether the current k8s cluster version is greater than 1.28. If so, it adds initContainer to the in-place

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign veophi for approval by writing /assign @veophi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 43.20988% with 46 lines in your changes missing coverage. Please review.

Project coverage is 48.80%. Comparing base (0d0031a) to head (ed192c8).
Report is 64 commits behind head on master.

Files Patch % Lines
pkg/control/sidecarcontrol/sidecarset_control.go 45.83% 13 Missing ⚠️
pkg/controller/sidecarset/sidecarset_processor.go 47.82% 9 Missing and 3 partials ⚠️
pkg/control/sidecarcontrol/util.go 0.00% 8 Missing ⚠️
pkg/webhook/sidecarset/validating/webhooks.go 0.00% 5 Missing ⚠️
pkg/control/pubcontrol/pub_control.go 0.00% 3 Missing and 1 partial ⚠️
pkg/control/sidecarcontrol/api.go 60.00% 1 Missing and 1 partial ⚠️
pkg/util/tools.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1698      +/-   ##
==========================================
+ Coverage   47.91%   48.80%   +0.88%     
==========================================
  Files         162      188      +26     
  Lines       23491    19347    -4144     
==========================================
- Hits        11256     9442    -1814     
+ Misses      11014     8670    -2344     
- Partials     1221     1235      +14     
Flag Coverage Δ
unittests 48.80% <43.20%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg zmberg added this to the 1.8 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants