Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed icon to toggle dark mode from light mode #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArshilHapani
Copy link

The Sun icon is not visible in light mode when the user has dark mode on their device but light mode on site.

Changes made at navigation.tsx
Line - 27
col - 221

When the user has dark mode on their device and switches to light mode on site then they cannot see the sun icon as it is stroked with a white colour

Footage of before
https://github.com/openjs-foundation/open-visualization/assets/108511809/417bef89-aaa3-4d4a-869a-bc134a39132d

After updated
https://github.com/openjs-foundation/open-visualization/assets/108511809/ca5d363f-7cfe-446a-8878-d56d90dc423f

Copy link

vercel bot commented Jun 26, 2024

@ArshilHapani is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibgreen
Copy link
Collaborator

ibgreen commented Jun 26, 2024

Ha ha no worries, if in doubt, just google it

https://google.com/search?q=LGTM

@ibgreen
Copy link
Collaborator

ibgreen commented Jun 26, 2024

Just a common comment when rubber stamping a small clean PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants