Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaFX Incubator Modules #1617

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 29, 2024

This PR contains a proposal for JavaFX Incubator Modules, along with an example incubator module might be implemented.

NOTE: This PR will remain in Draft and never be made rfr. It is intended only as supporting material for the proposal.

Notes to Reviewers

The source branch of this PR is based on the source branch of PR #1616, 8309381-incubator, which has the changes needed to support incubator modules. Click to see the diffs using that PR branch as the base.

This PR includes the following:

  1. The JavaFX Incubator Modules JEP and implementation notes.
  2. A sample incubator module, jfx.incubator.myfeature.

This jfx.incubator branch is meant to be illustrative in nature. It will never be integrated, so the PR based on this branch will remain in Draft state as long as the PR is open (it will never become rfr).

History

This supersedes an earlier Draft PR #1375


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1617/head:pull/1617
$ git checkout pull/1617

Update a local copy of the PR:
$ git checkout pull/1617
$ git pull https://git.openjdk.org/jfx.git pull/1617/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1617

View PR using the GUI difftool:
$ git pr show -t 1617

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1617.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant