Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a proposal for JavaFX Incubator Modules, along with an example incubator module might be implemented.
NOTE: This PR will remain in Draft and never be made
rfr
. It is intended only as supporting material for the proposal.Notes to Reviewers
The source branch of this PR is based on the source branch of PR #1616,
8309381-incubator
, which has the changes needed to support incubator modules. Click to see the diffs using that PR branch as the base.This PR includes the following:
jfx.incubator.myfeature
.This
jfx.incubator
branch is meant to be illustrative in nature. It will never be integrated, so the PR based on this branch will remain in Draft state as long as the PR is open (it will never becomerfr
).History
This supersedes an earlier Draft PR #1375
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1617/head:pull/1617
$ git checkout pull/1617
Update a local copy of the PR:
$ git checkout pull/1617
$ git pull https://git.openjdk.org/jfx.git pull/1617/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1617
View PR using the GUI difftool:
$ git pr show -t 1617
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1617.diff