6586559: Support for vertex colors

[Kneesnap]

Implements vertex color support for TriangleMesh.
Demonstrates a possible implementation of this feature proposal.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

• JDK-6586559: Support for vertex colors (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1557/head:pull/1557
$ git checkout pull/1557

Update a local copy of the PR:
$ git checkout pull/1557
$ git pull https://git.openjdk.org/jfx.git pull/1557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1557

View PR using the GUI difftool:
$ git pr show -t 1557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1557.diff

[bridgekeeper]

Hi @Kneesnap, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Kneesnap" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[Kneesnap]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[Kneesnap]

Dear reviewers, an application available for manual testing is available by running
C:\Program Files\Java\jdk-21\bin\java" -cp "{PATH TO JFX REPOSITORY}\apps\toys\FX8-3DFeatures\dist\FX8-3DFeatures.jar" --module-path "{PATH TO JFX REPOSITORY}\build\sdk\lib" --add-modules=javafx.controls,javafx.graphics fx83dfeatures.DynamicMeshViewer (You can run in any other way too)

[robilad]

hi, please send me an e-mail at [email protected] so that I can verify your account.

[bridgekeeper]

@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[Kneesnap]

New comment to avoid closure.

…

On Wed, Oct 16, 2024, 7:39 PM bridgekeeper[bot] ***@***.***> wrote: @Kneesnap <https://github.com/Kneesnap> This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! — Reply to this email directly, view it on GitHub <#1557 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSCIYN6S2NB5ZUIWPF4JZTZ34PPHAVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYGM3TCNJXGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bridgekeeper]

@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[Kneesnap]

Keep open! I'll take this as a reminder to finish this.

…

On Wed, Nov 13, 2024, 7:01 PM bridgekeeper[bot] ***@***.***> wrote: @Kneesnap <https://github.com/Kneesnap> This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! — Reply to this email directly, view it on GitHub <#1557 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSCIYL55ERP53SWL22ZBQD2AQG7ZAVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZVGMYTGNJUGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>