Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype VCS CI running on AWS #2236

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Prototype VCS CI running on AWS #2236

wants to merge 18 commits into from

Conversation

MikeOpenHWGroup
Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup commented Oct 11, 2023

This is a prototype of a VCS CI running on AWS. .github/workflows/aws.yml was provided by @zarubaf and I have not modified it in any meaningful way. The buildspec.yml file has been substantially changed and this is where reviewers should spend most of their time.

Other changes include updates to bin/ci_check to ensure it generates a valid and accurate return code and vcs.mk to minimize the size of the logfile generated.

This PR may not survive a review, but I am asking for your review now because there will be core-specific buildspecs in future PRs.

@MikeOpenHWGroup MikeOpenHWGroup added cv32e40p Common Infrastructure Library components or scriptware common to all environments in CORE-V-VERIF labels Oct 11, 2023
Comment on lines +4 to +7
# on:
# push:
# branches:
# - 'dev'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to change that, depending on when to trigger the job. Most l likely on PRs to dev I guess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct. I will be discussing the details of this with @rickoco (to understand our legal constraints) and the Members (to understand their expectations) and will update the trigger accordingly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it relates to the process which had been setup for cv32e40p: https://github.com/openhwgroup/cv32e40p#contributing

Comment on lines +21 to +26
# Questasim (vsim) environment
# - export QUESTAROOT=/onespin/questasim
# - export LM_LICENSE_FILE=29000@ip-172-31-46-244
# - export PATH=${QUESTAROOT}/bin:${PATH}
# - export MTI_VCO_MODE=64
# - wget https://buildbot.embecosm.com/job/corev-gcc-centos7/19/artifact/corev-openhw-gcc-centos7-20230905.tar.gz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the commented lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the commented lines will be removed before the Draft status of this PR is dropped. These were left in place to show you what I did to get Questasim (vsim) to run. It did not work. Perhaps the value of LM_LICENSE_FILE needs to be set to the same value as we are using for SNPSLMD_LICENSE_FILE? Any thoughts on this?

Copy link
Contributor

@silabs-hfegran silabs-hfegran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci_check script changes looks good to me - no immediate concerns there; as for the AWS related files I think that is best left up to others to review.


build:
commands:
- chown -R florian:florian .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not fully comprehend everything here, but are these scripts tied to a specific users account? should/could this be generalized?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question. The CI runs on a AWS VM instance that only OpenHW staff have access to. It could be any of us, but it cannot be "just anyone". It probably makes sense to create a generic "openhw-ci-runner" account that has its access privileges tuned to the CI requirements (and no more).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Infrastructure Library components or scriptware common to all environments in CORE-V-VERIF cv32e40p
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants