-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE_V_MCU high level design specs #328
Conversation
Hi @cst-rameez, thank you for this tremendous contribution to the CORE-V-MCU User Manual. It is much appreciated. I am in the process of reviewing the technical content and will leave my comments here. In the meantime there are two legal issues to resolve:
This is the License Header and it is a legal requirement that you maintain this. Of course, your organization is making a significant contribution, so you can add that to the License Header like this:
The next few lines in the comment header are intended as a helpful guide for editors to illustrate how to create section headers.
Lastly, this is a tag that can be used to create hyper-links between chapters, so it should remain.
|
@MikeOpenHWGroup @cst-rameez it appears the ECA is in good shape |
Really nice work. |
Really? The Eclipse ECA Validation Service says, "There is no valid ECA on file for [email protected]." and the eclipsefdn/eca check in this PR's run-flow is still failing. |
@cst-rameez my error. Can you please (as requested for the first pull request made to programs repo), log into your Eclipse Foundation Account and click the "I work for an employer who is an Eclipse Foundation member" and identify your employer. That should clear it. If that doesn't work, can you please ping me and we can chat live. |
Hi @DBees, I have updated my profile. could you please check what could be the problem now? |
HI @cst-rameez thank you. I have verified that your ECA status is now good. Can you please make an additional trivial commit (add a comma or a space). I think that should clear it here. |
Incorporated the following changes mentioned above. |
Adding high level design specs for the IPs which have insufficient information in core_v_mcu user manual https://docs.openhwgroup.org/projects/core-v-mcu/
Following are CORE-V-MCU IP blocks whose documents are updated:
APB Advanced Timer
APB SoC Controller
APB PLL Interface
APB_GPIO
APB Timer
ABP I2C Slave
APB Event Control
UDMA CAMERA Interface
UDMA SD Card Interface