Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getParsedDate - add 8h to account for timezone #963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix getParsedDate - add 8h to account for timezone #963

wants to merge 1 commit into from
+13 −5

Conversation

adriangohjw
Copy link
Contributor

Problem

date in collection preview is one day behind on studio

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Bug Fixes:

  • add a 8h addition to date to account for SG timezone

Before & After Screenshots

BEFORE:

Screenshot 2024-12-27 at 9 28 07 PM

AFTER:

Screenshot 2024-12-27 at 10 32 13 PM

Tests

  1. create a link in a collection
  2. select a date
  3. the date in the date selector and that in the preview should be the same

@adriangohjw adriangohjw added the bug Something isn't working label Dec 27, 2024
@adriangohjw adriangohjw self-assigned this Dec 27, 2024
@adriangohjw adriangohjw requested a review from a team as a code owner December 27, 2024 14:36
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 27, 2024 •
edited
Loading

Datadog Report

Branch report: fix-wrong-timezone-in-renderengine-in-studio
Commit report: bd1803d
Test service: isomer-studio

✅ 0 Failed, 245 Passed, 36 Skipped, 47.96s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.19%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adriangohjw adriangohjw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adriangohjw