feat(mrf be validation): enable mrf response validation hard block (#…

…7963) * feat: enable mrf response validation hard block * feat: add route mapping for FieldValidationErrorV3
opengovsg · Dec 2, 2024 · 3ee6f8f · 3ee6f8f
1 parent 4b6bc1e
commit 3ee6f8f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...pp/modules/submission/multirespondent-submission/multirespondent-submission.middleware.ts b/...pp/modules/submission/multirespondent-submission/multirespondent-submission.middleware.ts
@@ -531,16 +531,13 @@ export const validateMultirespondentSubmission = async (
                 })
               })
               .andThen((previousResponses) => {
-                // TODO: (FRM-1688) Set to block after sure that validation logic works as expected.
-                validateMrfFieldResponses({
+                return validateMrfFieldResponses({
                   formId,
                   visibleFieldIds,
                   formFields: form_fields,
                   responses: req.body.responses,
                   previousResponses,
                 })
-
-                return ok(req.body.responses)
               }),
           )
         },

diff --git a/src/app/modules/submission/submission.utils.ts b/src/app/modules/submission/submission.utils.ts
@@ -135,6 +135,7 @@ import {
   SubmissionSaveError,
   UnsupportedSettingsError,
   ValidateFieldError,
+  ValidateFieldErrorV3,
   VirusScanFailedError,
 } from './submission.errors'
 import {
@@ -309,6 +310,7 @@ const errorMapper: MapRouteError = (
           'Submission too large to be saved. Please reduce the size of your submission and try again.',
       }
     case ValidateFieldError:
+    case ValidateFieldErrorV3:
     case DatabaseValidationError:
     case InvalidFileExtensionError:
     case AttachmentTooLargeError: