Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the required fields of polaris when the config mode starts #1470

Merged
merged 10 commits into from
Oct 11, 2023

Conversation

mazengrun
Copy link
Contributor

feature: check the required fields of polaris when the config mode starts #1439

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (cf854b3) 34.34% compared to head (5b2d090) 34.25%.

❗ Current head 5b2d090 differs from pull request most recent head 0512ff7. Consider uploading reports for the commit 0512ff7 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1470      +/-   ##
=============================================
- Coverage      34.34%   34.25%   -0.10%     
  Complexity       848      848              
=============================================
  Files            262      262              
  Lines           5936     5953      +17     
  Branches         554      560       +6     
=============================================
  Hits            2039     2039              
- Misses          3704     3721      +17     
  Partials         193      193              
Files Coverage Δ
.../hippo4j/core/enable/BeforeCheckConfiguration.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weihubeats
Copy link
Member

weihubeats commented Oct 9, 2023

We also understand the wrong issues, the checks here are only for the ConfigurationProperties injected properties, and @value has nothing to do, so we actually do not have to consider the complexity, just need to BootstrapPropertiesInterface in the properties of the check can be

Copy link
Member

@weihubeats weihubeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weihubeats weihubeats merged commit 26212e4 into opengoofy:develop Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants