-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check the required fields of polaris when the config mode starts #1470
Conversation
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1470 +/- ##
=============================================
- Coverage 34.34% 34.25% -0.10%
Complexity 848 848
=============================================
Files 262 262
Lines 5936 5953 +17
Branches 554 560 +6
=============================================
Hits 2039 2039
- Misses 3704 3721 +17
Partials 193 193
☔ View full report in Codecov by Sentry. |
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Show resolved
Hide resolved
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
We also understand the wrong issues, the checks here are only for the ConfigurationProperties injected properties, and @value has nothing to do, so we actually do not have to consider the complexity, just need to |
threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feature: check the required fields of polaris when the config mode starts #1439