feature: hippo4j config model in zookeeper config before check (#1457)

opengoofy · Sep 18, 2023 · e98b106 · e98b106
1 parent 35cf5d8
commit e98b106
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/...mic/api/src/main/java/cn/hippo4j/threadpool/dynamic/api/BootstrapPropertiesInterface.java b/...mic/api/src/main/java/cn/hippo4j/threadpool/dynamic/api/BootstrapPropertiesInterface.java
@@ -94,4 +94,11 @@ default Map<String, String> getApollo() {
         return null;
     }
 
+    /**
+     * Get Zookeeper.
+     */
+    default Map<String, String> getZookeeper() {
+        return null;
+    }
+
 }
diff --git a/threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java b/threadpool/core/src/main/java/cn/hippo4j/core/enable/BeforeCheckConfiguration.java
@@ -115,6 +115,35 @@ public BeforeCheckConfiguration.BeforeCheck dynamicThreadPoolBeforeCheckBean(@Au
                                     "Please check whether the [spring.dynamic.thread-pool.apollo.namespace] configuration is empty or an empty string.");
                         }
                     }
+
+                    Map<String, String> zookeeper = properties.getZookeeper();
+                    if (MapUtil.isNotEmpty(zookeeper)) {
+                        String zkConnectStr = zookeeper.get("zk-connect-str");
+                        if ((StringUtil.isBlank(zkConnectStr))) {
+                            throw new ConfigEmptyException(
+                                    "Web server failed to start. The dynamic thread pool zookeeper zk-connect-str is empty.",
+                                    "Please check whether the [spring.dynamic.thread-pool.zookeeper.zk-connect-str] configuration is empty or an empty string.");
+                        }
+                        String configVersion = zookeeper.get("config-version");
+                        if ((StringUtil.isBlank(configVersion))) {
+                            throw new ConfigEmptyException(
+                                    "Web server failed to start. The dynamic thread pool zookeeper config-version is empty.",
+                                    "Please check whether the [spring.dynamic.thread-pool.zookeeper.config-version] configuration is empty or an empty string.");
+                        }
+                        String rootNode = zookeeper.get("root-node");
+                        if ((StringUtil.isBlank(rootNode))) {
+                            throw new ConfigEmptyException(
+                                    "Web server failed to start. The dynamic thread pool zookeeper root-node is empty.",
+                                    "Please check whether the [spring.dynamic.thread-pool.zookeeper.root-node] configuration is empty or an empty string.");
+                        }
+                        String node = zookeeper.get("node");
+                        if ((StringUtil.isBlank(node))) {
+                            throw new ConfigEmptyException(
+                                    "Web server failed to start. The dynamic thread pool zookeeper node is empty.",
+                                    "Please check whether the [spring.dynamic.thread-pool.zookeeper.node] configuration is empty or an empty string.");
+                        }
+                    }
+
                     break;
                 }
                 default: