Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cable Ready responses from User related controllers #12997

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wandji20
Copy link
Contributor

What? Why?

  • Closes #
    This is the first part of moving away from Cable Ready in favor of Hotwire related to Replace mrujs with turbo #12794

  • Since Turbo covers everything cable_ready does, we can safely move from cable_ready and mrujs to turbo.

This PR covers changes to the User Session, Password, Registration, and Confirmation Controllers.

What should we test?

The flow for user registration, login, password reset, and confirmation should be retained.

  • Visit ... page.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

Dependencies

N/A

Documentation updates

N/A

@wandji20 wandji20 marked this pull request as draft November 26, 2024 08:50
@wandji20 wandji20 marked this pull request as ready for review November 26, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Code review 🔎
Development

Successfully merging this pull request may close these issues.

1 participant