(Fix) Product description not correctly truncated

[wandji20]

What? Why?

• Closes Product description not correctly truncated #10685

Set CSS white-space property to normal and unify height and line-height CSS values

What should we test?

Test possible combinations of very long product descriptions with and without line breaks to confirm text is properly truncated.

Expected result

Release notes

N/A

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• Technical changes only

Dependencies

N/A

Documentation updates

N/A

[sigmundpetersen]

Hi @wandji20 👋 Thank you
There are some spec failures, can you have look?

[wandji20]

Hi @wandji20 👋 Thank you There are some spec failures, can you have look?

Hi @sigmundpetersen
All checks are passed after recommitting my work and force pushed.
However, I am on the fence as to why they failed with some Redis build error.

[sigmundpetersen]

Thanks, this is now ready for review. One of our developers will come back to you if there is any feedback 👍

[dacook]

Hello and welcome! Thanks for contribution, this looks like a good change but I think there might be an issue, can you please check?

[sigmundpetersen]

Hi @wandji20 the main branch build is currently broken, so the build errors here after rebase are not linked to your PR 👍

[wandji20]

Hi @wandji20 the main branch build is currently broken, so the build errors here after rebase is not linked to your PR 👍

Thank you @sigmundpetersen
So I can rebase again when failing specs are resolved

[mkllnk]

Thank you!

That looks like a great improvement. The confusion around this is that the original spec was to display two lines of text and truncate on the second line but nobody could make it work properly. So we decided to simplify and display only the first line of text. It looks like you fixed it now.

[rioug]

@wandji20 , the broken specs have been fixed in the main branch (#12644 ) . Could you rebase your PR ? Thanks ?

[wandji20]

@wandji20 , the broken specs have been fixed in the main branch (#12644 ) . Could you rebase your PR ? Thanks ?

Hi @rioug
This PR is now rebased

[rioug]

Looks good 👍 ! thanks for your help.

[drummer83]

Hi @wandji20,
Thank you for working on this fix! 💪

I have tested your PR on our staging server. Here is what I found.

Before your PR

I could reproduce the issue with incorrect truncation in width and height - even though I had to delete the HTML tags in the product description (see 'How to reproduce' above):

After your PR

It's looking good in Firefox. The text is truncated correctly:

I have also added an additional line break after the first sentence, which is displayed correctly as well:

I have also tested the Safari 17.3 browser on Sonoma using Browserstack:

Summary

It's all looking good and I couldn't spot any regressions. 👍
This one is ready to go! Merging! 🚀 🥳

Thanks again! 🙏