Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the login modal after sign-up and display message on home page #11597

Open
RachL opened this issue Sep 29, 2023 · 11 comments · May be fixed by #12639
Open

Close the login modal after sign-up and display message on home page #11597

RachL opened this issue Sep 29, 2023 · 11 comments · May be fixed by #12639
Labels
good first issue hackathon Issues for upcoming hackathons papercut Labels papercuts after they've moved from the "Papercuts prioritized" column

Comments

@RachL
Copy link
Contributor

RachL commented Sep 29, 2023

Description

- As a: new user
- On page: home page
- I want to be able to do:

currently if you sign up on the website, a message will be display to tell you an email was sent to you for confirmation; as this message appears within the modal, password managers like lastpass, bitwarden etc dont save the password as they require the login modal to close for this.
image

The purpose here is then to display the message on the home page instead of the modal.

Error messages should be kept within the modal.

Acceptance Criteria & Tests

  1. Register on the website
  2. Check the modal closes when clicking on "sign up now" and the user is redirected to the home page
  3. The message explaining the confirmation email appears on a home page flash banner
  4. Errors message like non matching passwords, wrong email... should be kept within the modal
@RachL RachL added good first issue hackathon Issues for upcoming hackathons papercut Labels papercuts after they've moved from the "Papercuts prioritized" column labels Sep 29, 2023
@chinmaym07
Copy link

Hi @RachL
Can I contribute to this ?

@RachL
Copy link
Contributor Author

RachL commented Sep 30, 2023

Hi @chinmaym07 yes of course! Welcome here :-) don't hesitate if you need help!!

@RachL
Copy link
Contributor Author

RachL commented Nov 20, 2023

Hello @chinmaym07 just checking in: are you still working on this?

@Thekote
Copy link

Thekote commented Dec 18, 2023

Hey @RachL can I take this one?

@RachL
Copy link
Contributor Author

RachL commented Dec 18, 2023

hi @Thekote yes please! don't hesitate to ping us on slack if you get stuck :)

@RachL
Copy link
Contributor Author

RachL commented Jan 12, 2024

Hello @Thekote I hope this message fins you well. I'm only checkin in here: are you still working on this issue?

@kellyzhangg
Copy link
Contributor

Is this still valid to be worked on? Thanks!

@RachL
Copy link
Contributor Author

RachL commented Apr 1, 2024

Hello @kellyzhangg and welcome! Yes this is still valid. Don't hesitate to reach us if you have any question!

@kellyzhangg
Copy link
Contributor

Sounds good! I'm not sure about the scope of this issue based on previous attempts adding more complexity than expected but if you want to assign this to me for now, that would be great! Thanks :)

@RachL
Copy link
Contributor Author

RachL commented Apr 4, 2024

Hi @kellyzhangg I see Sigmund has assigned you already, awesome :) Don't worry about previous contribution: we are indeed not looking at something more complex, a simple solution is perfect :) Many thanks in advance!

@sigmundpetersen
Copy link
Contributor

Hey @kellyzhangg hope you are fine 🙂
Are you still interested in working on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue hackathon Issues for upcoming hackathons papercut Labels papercuts after they've moved from the "Papercuts prioritized" column
Projects
Status: In Progress ⚙
Status: In progress
Development

Successfully merging a pull request may close this issue.

5 participants