Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close down login modal after sign up #394

Closed
Jesszahra opened this issue Dec 28, 2022 · 2 comments
Closed

Close down login modal after sign up #394

Jesszahra opened this issue Dec 28, 2022 · 2 comments

Comments

@Jesszahra
Copy link

What is the need / problem?

After sign up the login modal does not close. This is a problem as most password saving plugins such as chrome and last pass rely on the modal to be closed to trigger them to save the password. This will mean the user has to immediately click "forgotten password" after they sign up as (from memory) our site does not automatically log you in once you sign up. It also places a load on our servers for people clicking to retrieve password as they cannot use last pass or google.

This effects every single new user, and potentially other users if they haven't been able to save their passwords.

Potential solutions that will solve the problem ?

Close down the login modal after sign up. Check that this will trigger password saving functionality.

@RachL
Copy link
Contributor

RachL commented Apr 5, 2023

  • close the modal after sign-up
  • display the success flash banner on the home page instead of within the modal

image.png
image.png

=> this is a papercut

@BethanOFN BethanOFN added the UK Selected to be done by the UK instance label Jul 13, 2023
@RachL RachL removed the UK Selected to be done by the UK instance label Sep 29, 2023
@RachL
Copy link
Contributor

RachL commented Sep 29, 2023

I've opened openfoodfoundation/openfoodnetwork#11597 closing here

@RachL RachL closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants