Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoscaling values for ralph and superset #983

Merged
merged 3 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ At this point you should have a working Tutor / Aspects environment, but with no

You should now have data to look at in Superset! Log in to https://superset.local.overhang.io/ with your admin account and you should see charts with your data.

Aspects Autoscaling
-------------------

Aspects adds default autoscaling values for `Ralph`, `Superset` and the `Superset Worker` deployments via
`tutor-contrib-pod-autoscaling <https://github.com/eduNEXT/tutor-contrib-pod-autoscaling>`_. To apply the
autoscaling settings make sure to install the plugin and enable it. To modify the autoscaling values
see the `Configuration <https://github.com/eduNEXT/tutor-contrib-pod-autoscaling?tab=readme-ov-file#configuration>`_ section.

Superset Assets
---------------

Expand Down
1 change: 1 addition & 0 deletions requirements/dev.in
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ black
pyinstaller
pylint
twine
git+https://github.com/edunext/[email protected]
51 changes: 51 additions & 0 deletions tutoraspects/filters.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
"""Filters usage."""

from tutorpod_autoscaling.hooks import ( # pylint: disable=import-error
AUTOSCALING_CONFIG,
)


@AUTOSCALING_CONFIG.add()
def add_aspects_autoscaling(autoscaling_config):
"""Add autoscaling values for Aspects services."""
autoscaling_config.update(
{
"ralph": {
"enable_hpa": True,
"memory_request": "300Mi",
"cpu_request": 0.25,
"memory_limit": "600Mi",
"cpu_limit": 1,
"min_replicas": 1,
"max_replicas": 10,
"avg_cpu": 80,
"avg_memory": "",
"enable_vpa": False,
},
"superset": {
"enable_hpa": True,
"memory_request": "500Mi",
"cpu_request": 0.25,
"memory_limit": "1000Mi",
"cpu_limit": 1,
"min_replicas": 1,
"max_replicas": 10,
"avg_cpu": 80,
"avg_memory": "",
"enable_vpa": False,
},
"superset-worker": {
"enable_hpa": True,
"memory_request": "600Mi",
"cpu_request": 0.25,
"memory_limit": "1500Mi",
"cpu_limit": 1,
"min_replicas": 1,
"max_replicas": 10,
"avg_cpu": 80,
"avg_memory": "",
"enable_vpa": False,
},
}
)
return autoscaling_config
8 changes: 8 additions & 0 deletions tutoraspects/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -636,3 +636,11 @@ def _aspects_public_hosts(
# file for now.
for f in TUTOR_V1_COMMANDS:
hooks.Filters.CLI_COMMANDS.add_item(f)

# Autoscaling
try:
from tutoraspects.filters import ( # pylint: disable=unused-import
add_aspects_autoscaling,
)
except ImportError:
pass