Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes DBT_REPOSITORY_PATH #605

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Removes DBT_REPOSITORY_PATH #605

merged 2 commits into from
Feb 16, 2024

Conversation

pomegranited
Copy link
Contributor

Removes an unnecessary variable, and removes duplicated code from our init scripts.

Done while working on openedx/openedx-aspects#73.

in favour of hard-coding the git cloned directory name in the script,
because the name of the directory doesn't matter.
@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 16, 2024
@pomegranited pomegranited requested a review from bmtcril February 16, 2024 07:08
@Ian2012 Ian2012 merged commit be43197 into main Feb 16, 2024
6 checks passed
@Ian2012 Ian2012 deleted the jill/rm-dbt-repository-path branch February 16, 2024 14:22
@openedx-webhooks
Copy link

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants