-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add material symbols #3045
base: master
Are you sure you want to change the base?
feat: add material symbols #3045
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3045 +/- ##
==========================================
+ Coverage 93.18% 93.20% +0.02%
==========================================
Files 249 249
Lines 4342 4359 +17
Branches 1000 1036 +36
==========================================
+ Hits 4046 4063 +17
+ Misses 293 290 -3
- Partials 3 6 +3 ☔ View full report in Codecov by Sentry. |
When running
|
* Update from `@material-icons/svg` to `@material-design-icons/svg` * Add `@material-symbols/svg-400`
1314c44
to
6782c82
Compare
I was able to work around the issue by giving node more ram (8GB instead of the default 2) https://github.com/openedx/paragon/compare/1314c443e62567a57795776204faf79b47f547fb..6782c82efc14accece97f8747e4020c342f23e5b I have not investigated any impact on bundle size for MFEs consuming Paragon with this change yet. |
While you're at this, I noticed that all our icon function _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); } I found you can fix it with this change, which significantly reduces the total size of the |
Also, as far as I can tell, |
100% agree |
@material-icons/svg
to@material-design-icons/svg
@material-symbols/svg-400
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
https://deploy-preview-3045--paragon-openedx.netlify.app/foundations/icons/
Merge Checklist
example
app?Post-merge Checklist