-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add release workflow #115
Conversation
.github/workflows/pypi-publish.yaml
Outdated
|
||
push: | ||
runs-on: ubuntu-latest | ||
if: startsWith(github.ref, 'refs/tags/v') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only runs for vX.X.X tags (ignore harmony-chart-X.X.X)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be easier to just put it in a separate repo in the future, but this seems fine for now. I just wonder if we should use tags like harmony-plugin-X.X.X
instead of just vX.X.X
? I think that would be more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, now that versions will be available on PyPI, we can name it as we want. Let me know if I can trigger the workflow on a PR event temporarily to make sure everything is working and to have a first version on PyPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, go ahead and try it please :)
Thanks for the pull request, @Ian2012! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I was never asked to review this, from my side it looks good!
Plugin is on pipy already, a PR for adding harmony to tpi is already in progress: overhangio/tpi#5 I will close/open this PR as seems buggy |
This PR adds a release workflow to upload the tutor-contrib-harmony plugin to pypi.
This was tested on a fork: https://github.com/eduNEXT/openedx-k8s-harmony/actions/runs/12011623600/job/33481030042, it failed because the PyPi token was missing