Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Adds ADR 10. Localization #107

Merged
merged 2 commits into from
Jan 19, 2024
Merged

docs: Adds ADR 10. Localization #107

merged 2 commits into from
Jan 19, 2024

Conversation

pomegranited
Copy link
Contributor

@pomegranited pomegranited commented Jan 18, 2024 •
edited
Loading

Description

Documents our decision to translate Superset assets.

View rendered page here: 10. Localization of user-facing content

Supporting information

Part of #61

@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 18, 2024
@pomegranited pomegranited mentioned this pull request Jan 18, 2024
Closed
7 tasks
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jan 18, 2024
pomegranited
pomegranited commented Jan 19, 2024
View reviewed changes
docs/decisions/0010_localization.rst
Rejected Alternatives
*********************

**Translate assets on the fly with javascript**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ian2012 Are there any other rejected alternatives that I should document here? I just made this one up..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give support for asset translations in Superset apache/superset#13442

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with #110

Base automatically changed from jill/adr-pii to main January 19, 2024 17:56
@bmtcril bmtcril merged commit de0c47d into main Jan 19, 2024
3 checks passed
@bmtcril bmtcril deleted the jill/adr-l10n branch January 19, 2024 17:57
@openedx-webhooks
Copy link

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@pomegranited pomegranited mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ian2012 Ian2012 Ian2012 approved these changes

@bmtcril bmtcril bmtcril approved these changes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pomegranited @openedx-webhooks @Ian2012 @bmtcril @itsjeyd