-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add typescript files to coverage report #571
fix: add typescript files to coverage report #571
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Looks good 👍 The next would be do a test using this version in frontend-course-authoring
Sure @ChrisChV! @bradenmacdonald Could you help us to find a reviewer here? |
@rpenido I think codecov/patch is still running, could you check if is something about your changes? |
@ChrisChV I re-ran the CI and it seems fine now: openedx/frontend-app-authoring#1155 |
config/jest.config.js
Outdated
@@ -28,6 +28,7 @@ module.exports = { | |||
}, | |||
collectCoverageFrom: [ | |||
'src/**/*.{js,jsx}', | |||
'src/**/*.{ts,tsx}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd likely combine these lines into:
'src/**/*.{js,jsx,ts,tsx}',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Done: da2c6f3
b6a29a4
to
da2c6f3
Compare
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 14.0.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 15.0.0-alpha.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Currently,
ts
andtsx
files are not included in the coverage report. This PR updates thecollectCoverageFrom
param fromjest.config
to fix the issue.More information
Here is a
course-autoring
PR using a version with this change and the coverage report including ts files.